Skip to content

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport e186cf7 from #1857

Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
(cherry picked from commit e186cf7)
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1826 is missing

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1858 (25075ec) into 2.x (f2d5ed3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x    #1858   +/-   ##
=========================================
  Coverage     97.39%   97.39%           
  Complexity     4603     4603           
=========================================
  Files           401      401           
  Lines         11388    11388           
  Branches        843      843           
=========================================
  Hits          11091    11091           
  Misses          290      290           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MaxKsyunz
Copy link
Collaborator

#1826 is missing

Please provide a suggestion. PR title by itself does not include any relevant information.

(Same discussion in #1859)

@MaxKsyunz MaxKsyunz requested a review from Yury-Fridlyand July 12, 2023 17:51

* Updated documentation of round function return type ([#1725](https://github.com/opensearch-project/sql/pull/1725))
* Updated `protocol.rst` with new wording for error message ([#1662](https://github.com/opensearch-project/sql/pull/1662))

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Update docs to reflect recent changes. ([#1826](https://github.com/opensearch-project/sql/pull/1826)

### Infrastructure

* stopPrometheus task in doctest build.gradle now runs upon project failure in startOpenSearch ([#1747](https://github.com/opensearch-project/sql/pull/1747))
* Upgrade guava to 32.0.1
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Upgrade guava to 32.0.1
* Bump guava version to 32.0.1 ([#1829](https://github.com/opensearch-project/sql/pull/1829))
* Bump `log4j` version ([#1848](https://github.com/opensearch-project/sql/pull/1848))

Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, changes will be applied in another PR

@Yury-Fridlyand Yury-Fridlyand merged commit d14cce1 into 2.x Jul 12, 2023
@github-actions github-actions bot deleted the backport/backport-1857-to-2.x branch July 12, 2023 20:12
vamsimanohar pushed a commit to vamsimanohar/sql that referenced this pull request Jul 13, 2023
…ct#1858)

Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
(cherry picked from commit e186cf7)

Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
vamsimanohar pushed a commit to vamsimanohar/sql that referenced this pull request Jul 13, 2023
…ct#1858)

Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
(cherry picked from commit e186cf7)

Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
vamsimanohar pushed a commit to vamsimanohar/sql that referenced this pull request Jul 13, 2023
…ct#1858)

Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
(cherry picked from commit e186cf7)

Co-authored-by: Max Ksyunz <max.ksyunz@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants