Skip to content

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport e186cf7 from #1857

Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
(cherry picked from commit e186cf7)
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1826 is missing

@MaxKsyunz
Copy link
Collaborator

#1826 is missing

I didn't include that one because it was documenting something added in this release. It's generally expected that documentation and features are in sync.

I called out doc changes when they did not relate to software change in this release.

@MaxKsyunz MaxKsyunz requested a review from Yury-Fridlyand July 12, 2023 17:10
@Yury-Fridlyand
Copy link
Collaborator

#1826 include docs for #1821 too which is released in 2.9 and some things we missed for .. 2.7 or 2.6

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1859 (ef2f5f7) into 2.9 (02da891) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.9    #1859   +/-   ##
=========================================
  Coverage     97.34%   97.34%           
  Complexity     4524     4524           
=========================================
  Files           394      394           
  Lines         11166    11166           
  Branches        810      810           
=========================================
  Hits          10870    10870           
  Misses          289      289           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MaxKsyunz
Copy link
Collaborator

MaxKsyunz commented Jul 12, 2023

#1826 include docs for #1821 too which is released in 2.9 and some things we missed for .. 2.7 or 2.6

@Yury-Fridlyand please provide a suggestion of what you'd like to see in the release notes. What changes in those docs not related to 2.9 that would be relevant to a user?

I skipped this PR because it is not clear from the PR description what relevant, non-2.9 changes are.


* Updated documentation of round function return type ([#1725](https://github.com/opensearch-project/sql/pull/1725))
* Updated `protocol.rst` with new wording for error message ([#1662](https://github.com/opensearch-project/sql/pull/1662))

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Update docs to reflect recent changes. ([#1826](https://github.com/opensearch-project/sql/pull/1826)

### Infrastructure

* stopPrometheus task in doctest build.gradle now runs upon project failure in startOpenSearch ([#1747](https://github.com/opensearch-project/sql/pull/1747))
* Upgrade guava to 32.0.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Upgrade guava to 32.0.1
* Bump guava version to 32.0.1 ([#1829](https://github.com/opensearch-project/sql/pull/1829))
* Bump `log4j` version ([#1848](https://github.com/opensearch-project/sql/pull/1848))

Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, changes will be applied in another PR

@Yury-Fridlyand Yury-Fridlyand merged commit 912f99b into 2.9 Jul 12, 2023
@github-actions github-actions bot deleted the backport/backport-1857-to-2.9 branch July 12, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants