[release-v1.8] Populate a Subscriptions subscriber and reply namespace only if not set already#93
Conversation
…et already (knative#6671) Fixes knative#6539 In case a Subscription with a `.spec.subscriber.ref` pointing to a service in another namespace, the Subscription will not become ready because it is trying to find the service on the subscription's namespace (see knative#6539). Same happens with a subscriptions `.spec.reply.ref`. This PR addresses it and only uses the namespace of the Subscription, if no namespace was given for the subscriber/reply. ## Proposed Changes * 🐛 Populate a subscriptions subscriber & reply namespace field with the Subscriptions namespace only in case it is not set ### Pre-review Checklist - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** ```release-note ``` **How to verify** 1. Install a eventing with this patch 2. Create a sequence with steps and a reply in different namespaces (e.g. https://gist.github.com/creydr/57235f35b03ab8f1285eee0a64350576) 3. Check that the subscriptions and sequence becomes ready Signed-off-by: Christoph Stäbler <cstabler@redhat.com> (cherry picked from commit bd67450)
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
CP commands didn't work, so repeating them below |
|
/cherry-pick release-v1.7 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.7 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-v1.6 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.6 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pierDipi: new pull request created: #94 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pierDipi: new pull request created: #95 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Cherry-pick of knative#6671
/cherry-pick release-v1.7
/cherry-pick release-v1.6