[release-v1.6] Populate a Subscriptions subscriber and reply namespace only if not set already#95
Merged
openshift-merge-robot merged 1 commit intoopenshift-knative:release-v1.6from Jan 27, 2023
Conversation
…et already (knative#6671) Fixes knative#6539 In case a Subscription with a `.spec.subscriber.ref` pointing to a service in another namespace, the Subscription will not become ready because it is trying to find the service on the subscription's namespace (see knative#6539). Same happens with a subscriptions `.spec.reply.ref`. This PR addresses it and only uses the namespace of the Subscription, if no namespace was given for the subscriber/reply. ## Proposed Changes * 🐛 Populate a subscriptions subscriber & reply namespace field with the Subscriptions namespace only in case it is not set ### Pre-review Checklist - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** ```release-note ``` **How to verify** 1. Install a eventing with this patch 2. Create a sequence with steps and a reply in different namespaces (e.g. https://gist.github.com/creydr/57235f35b03ab8f1285eee0a64350576) 3. Check that the subscriptions and sequence becomes ready Signed-off-by: Christoph Stäbler <cstabler@redhat.com> (cherry picked from commit bd67450)
Collaborator
|
/retest |
1 similar comment
Member
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #93
/assign pierDipi