Skip to content

Skip 0 replica optimization #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Jun 11, 2021
Merged

Skip 0 replica optimization #1010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions knative-operator/deploy/resources/knativekafka/1-channel-consolidated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,9 +726,7 @@ metadata:
labels:
kafka.eventing.knative.dev/release: "v0.22.3"
spec:
# this deployment is going to be scaled up by the
# controller when the very first KafkaChannel is created
replicas: 0
replicas: 1
selector:
matchLabels:
messaging.knative.dev/channel: kafka-channel
Expand Down
15 changes: 15 additions & 0 deletions knative-operator/hack/001-eventing-kafkachannel_replicas1.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
diff --git a/knative-operator/deploy/resources/knativekafka/1-channel-consolidated.yaml b/knative-operator/deploy/resources/knativekafka/1-channel-consolidated.yaml
index 393457ce..23da885d 100644
--- a/knative-operator/deploy/resources/knativekafka/1-channel-consolidated.yaml
+++ b/knative-operator/deploy/resources/knativekafka/1-channel-consolidated.yaml
@@ -726,9 +726,7 @@ metadata:
labels:
kafka.eventing.knative.dev/release: "v0.22.3"
spec:
- # this deployment is going to be scaled up by the
- # controller when the very first KafkaChannel is created
- replicas: 0
+ replicas: 1
selector:
matchLabels:
messaging.knative.dev/channel: kafka-channel
5 changes: 4 additions & 1 deletion knative-operator/hack/update-manifests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,8 @@ function download_kafka {

download_kafka knativekafka "$KNATIVE_EVENTING_KAFKA_VERSION" "${kafka_files[@]}"

# We set the replica to 1, for now, while upstream has it 0.
git apply "$root/knative-operator/hack/001-eventing-kafkachannel_replicas1.patch"

# This is for SRVKE-807.
git apply "$root/knative-operator/hack/007-eventing-kafka-pdb.patch"
git apply "$root/knative-operator/hack/007-eventing-kafka-pdb.patch"