Skip 0 replica optimization#1010
Conversation
| @@ -728,7 +728,7 @@ metadata: | |||
| spec: | |||
| # this deployment is going to be scaled up by the | |||
| # controller when the very first KafkaChannel is created | |||
There was a problem hiding this comment.
nit: Should we remove this comment since default is 1?
There was a problem hiding this comment.
yeah, we can patch remove the comments too
|
/test 4.7-upgrade-tests-aws-ocp-47 |
Running make target for generated_files Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew
force-pushed
the
skip_0_replica_optimization
branch
from
7be0ff0 to
e61222b
Compare
|
@skonto I've changed the patch, to also remove the comments! Thanks for the feedback! |
|
/retest |
|
/retest Infra. |
|
/test 4.7-operator-e2e-aws-ocp-47 |
aliok
left a comment
aliok
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Let's see how it goes.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit cb84b0b.
6 participants
see if we are still better w/ default to
replicas: 1for the kafka channel deployment