Actually delete correct Kafka channel on cleanup#1006
Conversation
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
|
||
| t.Cleanup(func() { | ||
| _ = caCtx.Clients.Kafka.MessagingV1beta1().KafkaChannels(knativeKafkaNamespace).Delete(context.Background(), "", metav1.DeleteOptions{}) | ||
| _ = caCtx.Clients.Kafka.MessagingV1beta1().KafkaChannels(knativeKafkaNamespace).Delete(context.Background(), ch.Name, metav1.DeleteOptions{}) |
There was a problem hiding this comment.
Btw we should remove this in the future due to this downstream change that does not require a channel to be created to trigger the deployment: #1010
There was a problem hiding this comment.
not sure, yet ...
see also: #1010
but thanks for the pointer!
|
/retest |
markusthoemmes
force-pushed
the
delete-kafka-channel
branch
from
fef3759 to
ee0a28d
Compare
|
New changes are detected. LGTM label has been removed. |
|
@markusthoemmes: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
As per title.
/assign @skonto