Skip to content

Actually delete correct Kafka channel on cleanup #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markusthoemmes wants to merge 1 commit into from
Closed

Actually delete correct Kafka channel on cleanup #1006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2ekafka/knative_kafka_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func TestKnativeKafka(t *testing.T) {
}

t.Cleanup(func() {
_ = caCtx.Clients.Kafka.MessagingV1beta1().KafkaChannels(knativeKafkaNamespace).Delete(context.Background(), "", metav1.DeleteOptions{})
_ = caCtx.Clients.Kafka.MessagingV1beta1().KafkaChannels(knativeKafkaNamespace).Delete(context.Background(), ch.Name, metav1.DeleteOptions{})
Copy link
Copy Markdown
Collaborator

@skonto skonto Jun 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw we should remove this in the future due to this downstream change that does not require a channel to be created to trigger the deployment: #1010

Copy link
Copy Markdown
Member

@matzew matzew Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, yet ...
see also: #1010

but thanks for the pointer!

})

t.Run("verify correct deployment shape for KafkaChannel", func(t *testing.T) {
Expand Down