Skip to content

Revert "Adding patch for 1 replica (#1010)"#1018

Merged
openshift-merge-robot merged 1 commit into
openshift-knative:mainfrom
matzew:revert_replica_patch
Jun 15, 2021
Merged

Revert "Adding patch for 1 replica (#1010)"#1018
openshift-merge-robot merged 1 commit into
openshift-knative:mainfrom
matzew:revert_replica_patch

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Jun 14, 2021

This reverts commit cb84b0b.

Looks like this patch did not fix the glitch on the KnativeKafka e2e tests

/assign @aliok

Copy link
Copy Markdown
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Yeah, let's revert this and try to fix it some other way

@openshift-ci openshift-ci Bot added the lgtm label Jun 14, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 14, 2021

INFO[2021-06-14T08:34:14Z]     knative_kafka_test.go:121: Deployment kafka-ch-dispatcher is not gone: deployment kafka-ch-dispatcher in namespace knative-eventing not gone in time: timed out waiting for the condition 

/retest

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 15, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 78b6a0d into openshift-knative:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants