Skip to content

Including eventing-kafka upgrade tests for source and channel#1011

Merged
openshift-merge-robot merged 6 commits into
openshift-knative:mainfrom
cardil:feature/kafka-source-upgrade-tests
Jun 11, 2021
Merged

Including eventing-kafka upgrade tests for source and channel#1011
openshift-merge-robot merged 6 commits into
openshift-knative:mainfrom
cardil:feature/kafka-source-upgrade-tests

Conversation

@cardil
Copy link
Copy Markdown
Member

@cardil cardil commented Jun 9, 2021 •
edited
Loading

Port of #983 to main branch with 0.22 eventing

This PR requires also openshift/release#19133 to be merged

@cardil
Including eventing-kafka upgrade tests for source and channel
d6c660d 
Port of openshift-knative#983 to main branch with 0.22 eventing

* Including eventing-kafka upgrade tests for source and channel
* Change the eventing env prefix
* Removal of personal forks
* Testing if knative/eventing#5444 will fix the tests
* Fixing the config paths
* Removal of interim fork
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 9, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot requested review from devguyio and dsimansk June 9, 2021 15:24
cardil
cardil commented Jun 9, 2021
View reviewed changes
Comment thread go.mod Outdated
cardil
cardil commented Jun 9, 2021
View reviewed changes
Comment thread test/lib.bash Outdated
@cardil
Copy link
Copy Markdown
Member Author

cardil commented Jun 9, 2021

/test all

@cardil
Copy link
Copy Markdown
Member Author

cardil commented Jun 9, 2021

/retest

@cardil
Copy link
Copy Markdown
Member Author

cardil commented Jun 10, 2021

Here's a passing build on latest commit: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-knative_serverless-operator/1011/pull-ci-openshift-knative-serverless-operator-main-4.7-upgrade-tests-aws-ocp-47/1402743138010796032

Other failures are infra and eventing-kafka source test flakiness.

@cardil cardil mentioned this pull request Jun 10, 2021
Open
@cardil cardil marked this pull request as ready for review June 10, 2021 21:44
@cardil
Copy link
Copy Markdown
Member Author

cardil commented Jun 11, 2021

/retest

Looks like eventing flakes, not associated with this PR.

@cardil
Copy link
Copy Markdown
Member Author

cardil commented Jun 11, 2021

Merging #1010 with 21088d4 to help with eventing kafka CR flakes

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Jun 11, 2021

/lgtm
/hold
Putting on hold until all the checks pass. Feel free to unhold when they pass.

@openshift-ci openshift-ci Bot added the lgtm label Jun 11, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markusthoemmes
Copy link
Copy Markdown
Contributor

markusthoemmes commented Jun 11, 2021

/unhold

@openshift-merge-robot openshift-merge-robot merged commit 76af7dd into openshift-knative:main Jun 11, 2021
@cardil cardil deleted the feature/kafka-source-upgrade-tests branch June 11, 2021 11:15
@cardil cardil mentioned this pull request Jun 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devguyio devguyio Awaiting requested review from devguyio

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@mgencur mgencur

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cardil @mgencur @markusthoemmes @openshift-merge-robot