Skip to content

[1.15] Including eventing-kafka upgrade tests for source and channel#983

Merged
openshift-merge-robot merged 6 commits into
openshift-knative:release-1.15from
cardil:feature/kafka-source-upgrade-tests-p2
Jun 2, 2021
Merged

[1.15] Including eventing-kafka upgrade tests for source and channel#983
openshift-merge-robot merged 6 commits into
openshift-knative:release-1.15from
cardil:feature/kafka-source-upgrade-tests-p2

Conversation

@cardil
Copy link
Copy Markdown
Member

@cardil cardil commented May 25, 2021

This PR includes new upgrade tests from eventing-kafka for KafkaSource & KafkaChannel.

@cardil cardil requested review from matzew and mgencur May 25, 2021 16:34
@openshift-ci openshift-ci Bot requested review from dsimansk and warrenvw May 25, 2021 16:34
Comment thread go.mod Outdated
@cardil
Copy link
Copy Markdown
Member Author

cardil commented May 27, 2021

/retest

Comment thread go.mod Outdated
@cardil
Copy link
Copy Markdown
Member Author

cardil commented May 31, 2021

At @matzew @mgencur

Upgrade tests have passed with knative/eventing#5444 fix. We need to merge it and backport it.

@cardil cardil marked this pull request as draft May 31, 2021 22:11
@cardil cardil changed the title [1.15] Including eventing-kafka upgrade tests for source and channel [WIP][1.15] Including eventing-kafka upgrade tests for source and channel May 31, 2021
Comment thread test/upgrade/upgrade_test.go
@cardil cardil force-pushed the feature/kafka-source-upgrade-tests-p2 branch from 140e9c3 to 3f9539f Compare June 1, 2021 12:19
@cardil cardil changed the title [WIP][1.15] Including eventing-kafka upgrade tests for source and channel [1.15] Including eventing-kafka upgrade tests for source and channel Jun 1, 2021
@cardil cardil marked this pull request as ready for review June 1, 2021 12:20
@cardil
Copy link
Copy Markdown
Member Author

cardil commented Jun 1, 2021

Infra failure.

/retest

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Jun 2, 2021

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jun 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0b59eed into openshift-knative:release-1.15 Jun 2, 2021
@cardil cardil deleted the feature/kafka-source-upgrade-tests-p2 branch June 2, 2021 07:06
cardil added a commit to cardil/serverless-operator that referenced this pull request Jun 9, 2021
Port of openshift-knative#983 to main branch with 0.22 eventing

* Including eventing-kafka upgrade tests for source and channel
* Change the eventing env prefix
* Removal of personal forks
* Testing if knative/eventing#5444 will fix the tests
* Fixing the config paths
* Removal of interim fork
openshift-merge-robot pushed a commit that referenced this pull request Jun 11, 2021
* Including eventing-kafka upgrade tests for source and channel

Port of #983 to main branch with 0.22 eventing

* Including eventing-kafka upgrade tests for source and channel
* Change the eventing env prefix
* Removal of personal forks
* Testing if knative/eventing#5444 will fix the tests
* Fixing the config paths
* Removal of interim fork

* Interim: checking if upgrade tests will work with 0.21 test images

* Remove interim personal forks

* Revert "Interim: checking if upgrade tests will work with 0.21 test images"

This reverts commit 727308a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants