Skip to content

Mirror v0.21.1 test images of wathola#18873

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
cardil:feature/quay-mirror-wathola-kafka-sender
May 27, 2021
Merged

Mirror v0.21.1 test images of wathola#18873
openshift-merge-robot merged 1 commit into
openshift:masterfrom
cardil:feature/quay-mirror-wathola-kafka-sender

Conversation

@cardil
Copy link
Copy Markdown
Contributor

@cardil cardil commented May 27, 2021

Serverless operator in upgrade tests uses:

--imagetemplate quay.io/openshift-knative/{{.Name}}:v0.21 # for 1.15

Serverless Operator runs both serving, eventing and eventing kafka tests. That's why we can't use original registry.ci.openshift.org images as they contain a module prefix in them, and upgrade tests will not be able to find those images:

registry.ci.openshift.org/openshift/knative-v0.21.1:knative-eventing-kafka-test-wathola-kafka-sender
registry.ci.openshift.org/openshift/knative-v0.21.0:knative-serving-test-pizzaplanetv2

I think this PR is required so that openshift-knative/serverless-operator#983 can pass.

/cc @mgencur
/cc @matzew

@openshift-ci openshift-ci Bot requested review from matzew and mgencur May 27, 2021 07:53
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2021
@matzew
Copy link
Copy Markdown
Member

matzew commented May 27, 2021

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2021
registry.ci.openshift.org/openshift/knative-v0.21.0:knative-eventing-test-request-sender quay.io/openshift-knative/request-sender:v0.21.0
registry.ci.openshift.org/openshift/knative-v0.21.0:knative-eventing-test-request-sender quay.io/openshift-knative/request-sender:v0.21
registry.ci.openshift.org/openshift/knative-v0.21.0:knative-eventing-test-wathola-fetcher quay.io/openshift-knative/wathola-fetcher:v0.21.0
registry.ci.openshift.org/openshift/knative-v0.21.0:knative-eventing-test-wathola-fetcher quay.io/openshift-knative/wathola-fetcher:v0.21
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is from eventing . and it should stay

registry.ci.openshift.org/openshift/knative-v0.21.0:knative-eventing-test-wathola-receiver quay.io/openshift-knative/wathola-receiver:v0.21
registry.ci.openshift.org/openshift/knative-v0.21.0:knative-eventing-test-wathola-sender quay.io/openshift-knative/wathola-sender:v0.21.0
registry.ci.openshift.org/openshift/knative-v0.21.0:knative-eventing-test-wathola-sender quay.io/openshift-knative/wathola-sender:v0.21
registry.ci.openshift.org/openshift/knative-v0.21.1:knative-eventing-kafka-test-wathola-fetcher quay.io/openshift-knative/wathola-fetcher:v0.21.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is from eventing-kafka ... and should perhaps be on a diferent repi ?

registry.ci.openshift.org/openshift/knative-v0.21.1:knative-eventing-kafka-test-wathola-sender quay.io/openshift-knative/wathola-sender:v0.21.1
registry.ci.openshift.org/openshift/knative-v0.21.1:knative-eventing-kafka-test-wathola-sender quay.io/openshift-knative/wathola-sender:v0.21
registry.ci.openshift.org/openshift/knative-v0.21.1:knative-eventing-kafka-test-wathola-kafka-sender quay.io/openshift-knative/wathola-kafka-sender:v0.21.1
registry.ci.openshift.org/openshift/knative-v0.21.1:knative-eventing-kafka-test-wathola-kafka-sender quay.io/openshift-knative/wathola-kafka-sender:v0.21
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have the repos, yet - right ?

registry.ci.openshift.org/openshift/knative-v0.21.0:knative-eventing-test-wathola-sender quay.io/openshift-knative/wathola-sender:v0.21
registry.ci.openshift.org/openshift/knative-v0.21.1:knative-eventing-kafka-test-wathola-fetcher quay.io/openshift-knative/wathola-fetcher:v0.21.1
registry.ci.openshift.org/openshift/knative-v0.21.1:knative-eventing-kafka-test-wathola-fetcher quay.io/openshift-knative/wathola-fetcher:v0.21
registry.ci.openshift.org/openshift/knative-v0.21.1:knative-eventing-kafka-test-wathola-forwarder quay.io/openshift-knative/wathola-forwarder:v0.21.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quay.io/openshift-knative/eventing-kafka-wathola-forwarder is a better pre fix

@matzew
Copy link
Copy Markdown
Member

matzew commented May 27, 2021

as discussed w/ @cardil on call. we go with this.

Perhaps we have to re-adjust the names of the additional kafka repo images.

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit d471ea9 into openshift:master May 27, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2021

@cardil: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_knative_v0_21_quay using file core-services/image-mirroring/knative/mapping_knative_v0_21_quay
Details

In response to this:

Serverless operator in upgrade tests uses:

--imagetemplate quay.io/openshift-knative/{{.Name}}:v0.21 # for 1.15

Serverless Operator runs both serving, eventing and eventing kafka tests. That's why we can't use original registry.ci.openshift.org images as they contain a module prefix in them, and upgrade tests will not be able to find those images:

registry.ci.openshift.org/openshift/knative-v0.21.1:knative-eventing-kafka-test-wathola-kafka-sender
registry.ci.openshift.org/openshift/knative-v0.21.0:knative-serving-test-pizzaplanetv2

I think this PR is required so that openshift-knative/serverless-operator#983 can pass.

/cc @mgencur
/cc @matzew

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil cardil deleted the feature/quay-mirror-wathola-kafka-sender branch May 27, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants