Skip to content

Do not override wathola images from eventing core#19131

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
cardil:bugfix/dont-override-wathola-images
Jun 9, 2021
Merged

Do not override wathola images from eventing core#19131
openshift-merge-robot merged 1 commit into
openshift:masterfrom
cardil:bugfix/dont-override-wathola-images

Conversation

@cardil
Copy link
Copy Markdown
Contributor

@cardil cardil commented Jun 9, 2021

Restoring image mirroring for 0.21 for eventing core, that was configured in #18873 so that eventing-kafka wathola test images would override eventing core images.

This change restore mirroring of original eventing core test images, and leave only wathola-kafka-sender to be mirrored from eventing kafka.

@openshift-ci openshift-ci Bot requested review from markusthoemmes and matzew June 9, 2021 15:52
@cardil
Copy link
Copy Markdown
Contributor Author

cardil commented Jun 9, 2021

/cc @matzew

Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0fce00c into openshift:master Jun 9, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 9, 2021

@cardil: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_knative_v0_21_quay using file core-services/image-mirroring/knative/mapping_knative_v0_21_quay
Details

In response to this:

Restoring image mirroring for 0.21 for eventing core, that was configured in #18873 so that eventing-kafka wathola test images would override eventing core images.

This change restore mirroring of original eventing core test images, and leave only wathola-kafka-sender to be mirrored from eventing kafka.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil cardil deleted the bugfix/dont-override-wathola-images branch June 10, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants