Skip to content

Adding wathola-kafka-sender test image for 0.22 release#19133

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
cardil:feature/0.22/wathola-kafka-sender
Jun 10, 2021
Merged

Adding wathola-kafka-sender test image for 0.22 release#19133
openshift-merge-robot merged 1 commit into
openshift:masterfrom
cardil:feature/0.22/wathola-kafka-sender

Conversation

@cardil
Copy link
Copy Markdown
Contributor

@cardil cardil commented Jun 9, 2021 •
edited
Loading

Similar as #18852 but for 0.22 release

Also, similar to #19131 adding to mirroring only the new image, without overriding eventing core images.

This PR depends on openshift-knative/eventing-kafka#233

/cc @matzew

@cardil
Adding wathola-kafka-sender test image
93597a1 
release
Similar as openshift#18852 but for 0.22 release
@openshift-ci openshift-ci Bot requested a review from matzew June 9, 2021 16:09
@cardil cardil mentioned this pull request Jun 9, 2021
Merged
@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 9, 2021

/retest

@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 10, 2021 via email

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2021
@cardil
Copy link
Copy Markdown
Contributor Author

cardil commented Jun 10, 2021

This PR depends on openshift-knative/eventing-kafka#233. I wrote that on PR description.

matzew
matzew approved these changes Jun 10, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2021
@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 10, 2021

This PR depends on openshift-knative/eventing-kafka#233. I wrote that on PR description.

ah, cool - thanks!

@cardil
Copy link
Copy Markdown
Contributor Author

cardil commented Jun 10, 2021

/retest

@cardil
Copy link
Copy Markdown
Contributor Author

cardil commented Jun 10, 2021

openshift-knative/eventing-kafka#233 is now merged

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 10, 2021

@cardil: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift-knative/eventing-kafka/release-v0.22.0/47-e2e-aws-ocp-47 93597a1 link /test pj-rehearse
ci/prow/pj-rehearse 93597a1 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-knative-eventing-kafka-release-v0.22.0-47-e2e-aws-ocp-47-continuous 93597a1 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c1abb0b into openshift:master Jun 10, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 10, 2021

@cardil: Updated the following 2 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-eventing-kafka-release-v0.22.0__47.yaml using file ci-operator/config/openshift-knative/eventing-kafka/openshift-knative-eventing-kafka-release-v0.22.0__47.yaml
  • image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
    • key mapping_knative_v0_22_quay using file core-services/image-mirroring/knative/mapping_knative_v0_22_quay
Details

In response to this:

Similar as #18852 but for 0.22 release

Also, similar to #19131 adding to mirroring only the new image, without overriding eventing core images.

This PR depends on openshift-knative/eventing-kafka#233

/cc @matzew

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil cardil deleted the feature/0.22/wathola-kafka-sender branch June 10, 2021 21:02
@cardil cardil mentioned this pull request Jun 25, 2021
Merged
cardil added a commit to cardil/openshift-release that referenced this pull request Jun 29, 2021
@cardil
Adding wathola-kafka-sender test image
b447eaf 
Similar as openshift#19133 but for 0.23 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@matzew matzew matzew approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cardil @matzew @openshift-merge-robot