Eventing and Kafka 0.24.x by matzew · Pull Request #1153 · openshift-knative/serverless-operator

matzew · 2021-08-23T07:56:45Z

lets see how this goes...

matzew · 2021-08-23T09:06:12Z

Will wait for the 0.24.3 version of eventing-kafka, to have them alligned

matzew · 2021-08-24T12:50:41Z

Is not ready..... blocked on:

[0.24] Patch subresource to unblock webhooks on 4.9 (#308) eventing-kafka#312
[0.24] Patch subresource to unblock webhooks on 4.9 (#1361) openshift/knative-eventing#1365

Afterwards this needs a re-spin

markusthoemmes · 2021-09-02T14:40:53Z

KafkaChannel.messaging.knative.dev \"e2e-singleevent-channel-binary\" is invalid: status.address: Required value

sounds quite relevant. The CRD is asking for this field to be filled in.

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

This reverts commit 40c7aa8.

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

…ka 0.24.x bits Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

matzew · 2021-09-02T16:06:42Z

yeah. on it - we also have some backports. Still WIP Due to 1.17 fu 😂

On Thu 2. Sep 2021 at 16:41, Markus Thömmes ***@***.***> wrote: KafkaChannel.messaging.knative.dev \"e2e-singleevent-channel-binary\" is invalid: status.address: Required value sounds quite relevant. The CRD is asking for this field to be filled in. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1153 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABGPTXSORLWP46RENBXEHTT76EIBANCNFSM5CUAHYNQ> .

-- Sent from Gmail Mobile

matzew · 2021-09-02T16:07:27Z

but thanks for looking!

On Thu 2. Sep 2021 at 18:06, Matthias Wessendorf ***@***.***> wrote: yeah. on it - we also have some backports. Still WIP Due to 1.17 fu 😂 On Thu 2. Sep 2021 at 16:41, Markus Thömmes ***@***.***> wrote: > KafkaChannel.messaging.knative.dev \"e2e-singleevent-channel-binary\" is invalid: status.address: Required value > > sounds quite relevant. The CRD is asking for this field to be filled in. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#1153 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AABGPTXSORLWP46RENBXEHTT76EIBANCNFSM5CUAHYNQ> > . > -- Sent from Gmail Mobile

-- Sent from Gmail Mobile

matzew · 2021-09-03T09:28:34Z

-data:
-  # Broker URL. Replace this with the URLs for your kafka cluster,
-  # which is in the format of my-cluster-kafka-bootstrap.my-kafka-namespace:9092.
-  bootstrapServers: REPLACE_WITH_CLUSTER_URL
-  #authSecretName: name-of-your-secret-for-kafka-auth
-  #authSecretNamespace: namespace-of-your-secret-for-kafka-auth


we should keep this instead of the kafka.brokers

already captured as https://issues.redhat.com/browse/SRVKE-812

Will take a look next week ...

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

matzew · 2021-09-03T11:59:34Z

@mgencur can you take a look here:

 ERROR:   🚨 Error (code: 1) occurred at /go/src/knative.dev/eventing/openshift/e2e-common.sh:27, with command: cat  <<-END$KNATIVE_EVENTING_TEST_RECORDEVENTSEND

that's this line here: https://github.com/openshift/knative-eventing/blob/release-v0.24/openshift/e2e-common.sh#L27

markusthoemmes · 2021-09-03T13:03:50Z

I guess that ain't going to work because all those variables are unset for the serverless-operator.

mgencur · 2021-09-06T06:50:18Z

@matzew @markusthoemmes Sent fix for the script sourcing in openshift/knative-eventing#1394

mgencur · 2021-09-06T09:09:29Z

/retest
openshift/knative-eventing#1394 was merged. Retesting

mgencur · 2021-09-06T10:28:09Z

@matzew tests passed.

matzew · 2021-09-06T13:19:29Z

Nice!

This is ready...

markusthoemmes · 2021-09-07T10:47:29Z

Let's give this one more whack, to rule out flakiness or whatever.

/test foo

openshift-ci · 2021-09-07T10:47:30Z

@markusthoemmes: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 4.6-images
/test 4.7-images
/test 4.8-aws-ovn-images
/test 4.8-azure-images
/test 4.8-gcp-images
/test 4.8-images
/test 4.8-operator-e2e-aws-ocp-48
/test 4.8-vsphere-images
/test 4.9-images
/test unit-test

The following commands are available to trigger optional jobs:

/test 4.8-upgrade-tests-aws-ocp-48
/test 4.8-upstream-e2e-aws-ocp-48
/test 4.8-upstream-e2e-mesh-aws-ocp-48

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-serverless-operator-main-4.8-images
pull-ci-openshift-knative-serverless-operator-main-4.8-operator-e2e-aws-ocp-48
pull-ci-openshift-knative-serverless-operator-main-4.8-upgrade-tests-aws-ocp-48
pull-ci-openshift-knative-serverless-operator-main-4.8-upstream-e2e-aws-ocp-48
pull-ci-openshift-knative-serverless-operator-main-unit-test

Details

In response to this:

Let's give this one more whack, to rule out flakiness or whatever.

/test foo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

markusthoemmes · 2021-09-07T10:47:51Z

/test 4.8-operator-e2e-aws-ocp-48
/test 4.8-upstream-e2e-aws-ocp-48
/test 4.8-upgrade-tests-aws-ocp-48

markusthoemmes

/lgtm
/approve

openshift-ci · 2021-09-07T12:02:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [markusthoemmes,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci Bot added the do-not-merge/work-in-progress label Aug 23, 2021

openshift-ci Bot requested review from mgencur and skonto August 23, 2021 07:56

openshift-ci Bot added the approved label Aug 23, 2021

matzew force-pushed the eventing_0.24 branch from 5153f43 to 85828d1 Compare August 24, 2021 12:49

matzew changed the title ~~WIP: Eventing 0.24~~ WIP: Eventing and Kafka 0.24.x Aug 24, 2021

matzew force-pushed the eventing_0.24 branch 2 times, most recently from 485cb80 to fd6fab1 Compare August 25, 2021 14:45

openshift-ci Bot added the needs-rebase label Aug 29, 2021

matzew force-pushed the eventing_0.24 branch from fd6fab1 to 658f5a7 Compare August 31, 2021 14:09

openshift-ci Bot removed the needs-rebase label Aug 31, 2021

matzew force-pushed the eventing_0.24 branch from 658f5a7 to 1965b0c Compare September 2, 2021 14:50

matzew added 8 commits September 2, 2021 17:35

Bump the eventing manifests

87c25d7

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Fix patch content based on new version

68d7447

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Bump the kafkas to 0.24.3

0218bed

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Removing the kafkasource migration yaml job.

d8f997f

This reverts commit 40c7aa8.

Adding the post job to the download artifact section

0e3495a

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Running make generated-files for downloading the all the Eventing/Kaf…

85f47c4

…ka 0.24.x bits Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Adding patch for better BatchJob names...

4144bae

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Running make generated-files to patch the BatchJob name

fb48b50

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

matzew force-pushed the eventing_0.24 branch from 1965b0c to fb48b50 Compare September 2, 2021 15:36

matzew commented Sep 3, 2021

View reviewed changes

matzew added 2 commits September 3, 2021 11:39

Adding one more patch

de58fec

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Running make generated-files...

b926f3f

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

mgencur mentioned this pull request Sep 6, 2021

[release-v0.24] Do not set TEST_IMAGE_TEMPLATE in e2e-commons.sh openshift/knative-eventing#1394

Merged

5 tasks

matzew changed the title ~~WIP: Eventing and Kafka 0.24.x~~ Eventing and Kafka 0.24.x Sep 6, 2021

openshift-ci Bot removed the do-not-merge/work-in-progress label Sep 6, 2021

markusthoemmes approved these changes Sep 7, 2021

View reviewed changes

openshift-ci Bot assigned markusthoemmes Sep 7, 2021

openshift-ci Bot added the lgtm label Sep 7, 2021

openshift-merge-robot merged commit 5257d24 into openshift-knative:main Sep 7, 2021

Conversation

matzew commented Aug 23, 2021

Uh oh!

matzew commented Aug 23, 2021

Uh oh!

matzew commented Aug 24, 2021

Uh oh!

markusthoemmes commented Sep 2, 2021

Uh oh!

matzew commented Sep 2, 2021 via email

Uh oh!

matzew commented Sep 2, 2021 via email

Uh oh!

matzew Sep 3, 2021

Choose a reason for hiding this comment

Uh oh!

matzew Sep 3, 2021

Choose a reason for hiding this comment

Uh oh!

matzew commented Sep 3, 2021

Uh oh!

markusthoemmes commented Sep 3, 2021

Uh oh!

mgencur commented Sep 6, 2021

Uh oh!

mgencur commented Sep 6, 2021

Uh oh!

mgencur commented Sep 6, 2021

Uh oh!

matzew commented Sep 6, 2021

Uh oh!

markusthoemmes commented Sep 7, 2021

Uh oh!

openshift-ci Bot commented Sep 7, 2021

Uh oh!

markusthoemmes commented Sep 7, 2021

Uh oh!

markusthoemmes left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Sep 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants