Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

[0.24] Patch subresource to unblock webhooks on 4.9 (#1361)#1365

Merged
openshift-merge-robot merged 1 commit into
openshift:release-v0.24from
matzew:backport_1361_to_0.24
Aug 24, 2021
Merged

[0.24] Patch subresource to unblock webhooks on 4.9 (#1361)#1365
openshift-merge-robot merged 1 commit into
openshift:release-v0.24from
matzew:backport_1361_to_0.24

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Aug 20, 2021

Done for [SRVKS-790]. See #1361 for reference

@openshift-ci openshift-ci Bot requested review from devguyio and lberk August 20, 2021 07:24
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2021
Copy link
Copy Markdown
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
Copy link
Copy Markdown

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, markusthoemmes, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [aliok,markusthoemmes,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Aug 24, 2021

/retest

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit cef96eb into openshift:release-v0.24 Aug 24, 2021
openshift-merge-robot pushed a commit that referenced this pull request Oct 4, 2021
* Revert "[SRVKS-790] Patch subresource to unblock webhooks on 4.9 (#1361) (#1365)"

This reverts commit cef96eb.

* upgrade to latest dependencies (knative#5707)

bumping knative.dev/pkg dd0db4b...953af01:
  > 953af01 [release-0.24] allow unknown metadata fields (# 2255)
  > 03e7ca5 Drop redundant pointers and decoders (# 2260)

Signed-off-by: Knative Automation <automation@knative.team>

Co-authored-by: knative-automation <automation@knative.team>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants