Skip to content

Bump to 1.23#1479

Merged
openshift-merge-robot merged 2 commits into
openshift-knative:mainfrom
matzew:bump_to_1.23
Apr 8, 2022
Merged

Bump to 1.23#1479
openshift-merge-robot merged 2 commits into
openshift-knative:mainfrom
matzew:bump_to_1.23

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Apr 7, 2022

let's have these as single, atomic PRs, and not as a big all update shot PR

matzew added 2 commits April 7, 2022 11:49
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@openshift-ci openshift-ci Bot requested review from alanfx and dsimansk April 7, 2022 10:13
@openshift-ci openshift-ci Bot added the approved label Apr 7, 2022
@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Apr 7, 2022

/retest

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Apr 7, 2022

/test 4.10-upgrade-tests-aws-ocp-410

@skonto
Copy link
Copy Markdown
Collaborator

skonto commented Apr 7, 2022

@matzew Usually we do this after openshift/release#27522 is merged. I guess it will not create issues since we dont touch the knative operator version. Openshift serving uses the S-O scripts to install the operator and it depends on the current version for the applied manifest to work.

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Apr 7, 2022

@skonto usually this was the very first Markus and did in the past

the version of Serverless Operator is independent of any operands - hence, IMO this is the canonical first shot

Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2d4c761 into openshift-knative:main Apr 8, 2022
@skonto skonto mentioned this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants