Run CI for 1.2.0 serving, net-istio and net-kourier release by skonto · Pull Request #27522 · openshift/release

skonto · 2022-04-04T11:24:49Z

As per title, needed for Serverless 1.23.

skonto · 2022-04-04T11:25:23Z

This has to be 1.16 or 1.17? In previous versions we have this as 1.16.

IMO would be nice if we align, no ?

skonto · 2022-04-04T13:28:06Z

error: error copying source path /go/bin/volumes to .: exit status 1

Updated openshift/serving release-v1.2.0 branch with pvc support.

skonto · 2022-04-04T13:29:48Z

/retest

skonto · 2022-04-04T14:26:21Z

{"severity":"ERROR","timestamp":"2022-04-04T14:07:39.742782904Z","logger":"knative-operator","caller":"common/stages.go:84","message":"Unable to fetch installed manifest, trying targetthe version of the manifests v1.2.0 of the component knative-serving does not match the target version of the operator CR v1.1.2","knative.dev/pod":"knative-operator-55b8487775-

Had to revert the label update needs to happen, after S-O is setup with the new Serving version.

skonto · 2022-04-05T18:47:13Z

/retest

skonto · 2022-04-07T14:45:13Z

+ oc create namespace istio-system
The connection to the server api.ci-ocp-4-10-amd64-aws-us-east-1-pfmkr.hive.aws.ci.openshift.org:6443 was refused - did you specify the right host or port?
+ for ns in '"${namespaces[@]}"'

skonto · 2022-04-07T14:45:52Z

/retest

matzew · 2022-04-07T15:49:45Z

+  image_stream_tag:
+    name: release
+    namespace: openshift
+    tag: golang-1.16


but this is 1.16 too ...

yes relic from the previous setup will update and test

@nak3 do we care about it? I just updated to 1.17 any concerns?

skonto · 2022-04-07T19:11:38Z

infra

skonto · 2022-04-07T19:57:55Z

   autoscale_hpa_test.go:74: Error collecting metrics by HPA: timed out waiting for the condition
--- FAIL: TestHPAAutoscaleUpDownUp (907.59s)
FAIL test/e2e.TestHPAAutoscaleUpDownUp (907.59s)
FAIL test/e2e

=== Skipped
=== SKIP: test/e2e TestHPAAutoscaleUpDownUpMem (0.00s)
    autoscale_hpa_test.go:64: #11944: Skipped because of excessive flakiness

=== Failed
=== FAIL: test/e2e TestHPAAutoscaleUpDownUp (907.59s)

skonto · 2022-04-07T20:01:38Z

We still suffer from the pdb issue on 4.6, 4.7:

{"type":"InstallSucceeded","status":"False","lastTransitionTime":"2022-04-07T19:22:54Z","reason":"Error","message":"Install failed with message: no matches for kind \"PodDisruptionBudget\" in version \"policy/v1\""},

{"severity":"ERROR","timestamp":"2022-04-07T15:31:36.534320738Z","logger":"knative-operator","caller":"controller/controller.go:566","message":"Reconcile error","knative.dev/pod":"knative-operator-7b57c45999-tb9db","knative.dev/controller":"knative.dev.operator.pkg.reconciler.knativeserving.Reconciler","knative.dev/kind":"operator.knative.dev.KnativeServing","knative.dev/traceid":"e007b542-a117-4bef-9255-adf37959030b","knative.dev/key":"knative-serving/knative-serving","duration":"10.332428755s","error":"failed to apply non rbac manifest: no matches for kind \"PodDisruptionBudget\" in version \"policy/v1\"","stacktrace":"knative.dev/pkg/controller.(*Impl).handleErr\n\t/go/src/github.com/openshift-knative/serverless-operator/vendor/knative.dev/pkg/controller/controller.go:566\nknative.dev/pkg/controller.(*Impl).processNextWorkItem\n\t/go/src/github.com/openshift-knative/serverless-operator/vendor/knative.dev/pkg/controller/controller.go:543\nknative.dev/pkg/controller.(*Impl).RunContext.func3\n\t/go/src/github.com/openshift-knative/serverless-operator/vendor/knative.dev/pkg/controller/controller.go:478"}

Fixed it by applying again the removed patch here. We can still use it until 4.12.

skonto · 2022-04-07T20:44:06Z

/retest

skonto · 2022-04-07T22:33:03Z

@matzew @nak3 pls approve.

nak3 · 2022-04-08T02:00:49Z

/lgtm

openshift-ci · 2022-04-08T02:01:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift-knative/net-istio/OWNERS~~ [nak3,skonto]
~~ci-operator/config/openshift-knative/net-kourier/OWNERS~~ [nak3,skonto]
~~ci-operator/config/openshift/knative-serving/OWNERS~~ [nak3,skonto]
~~ci-operator/jobs/openshift-knative/net-istio/OWNERS~~ [nak3,skonto]
~~ci-operator/jobs/openshift-knative/net-kourier/OWNERS~~ [nak3,skonto]
~~ci-operator/jobs/openshift/knative-serving/OWNERS~~ [nak3,skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-04-08T02:09:09Z

@skonto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-04-08T02:10:36Z

@skonto: Updated the following 2 configmaps:

ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
- key openshift-knative-net-istio-release-1.2.yaml using file ci-operator/config/openshift-knative/net-istio/openshift-knative-net-istio-release-1.2.yaml
- key openshift-knative-net-kourier-release-1.2.yaml using file ci-operator/config/openshift-knative/net-kourier/openshift-knative-net-kourier-release-1.2.yaml
- key openshift-knative-serving-release-v1.2.0__4.10.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-v1.2.0__4.10.yaml
- key openshift-knative-serving-release-v1.2.0__4.6.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-v1.2.0__4.6.yaml
- key openshift-knative-serving-release-v1.2.0__4.7.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-v1.2.0__4.7.yaml
- key openshift-knative-serving-release-v1.2.0__4.8.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-v1.2.0__4.8.yaml
- key openshift-knative-serving-release-v1.2.0__4.9.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-v1.2.0__4.9.yaml
job-config-misc configmap in namespace ci at cluster app.ci using the following files:
- key openshift-knative-net-istio-release-1.2-postsubmits.yaml using file ci-operator/jobs/openshift-knative/net-istio/openshift-knative-net-istio-release-1.2-postsubmits.yaml
- key openshift-knative-net-istio-release-1.2-presubmits.yaml using file ci-operator/jobs/openshift-knative/net-istio/openshift-knative-net-istio-release-1.2-presubmits.yaml
- key openshift-knative-net-kourier-release-1.2-postsubmits.yaml using file ci-operator/jobs/openshift-knative/net-kourier/openshift-knative-net-kourier-release-1.2-postsubmits.yaml
- key openshift-knative-net-kourier-release-1.2-presubmits.yaml using file ci-operator/jobs/openshift-knative/net-kourier/openshift-knative-net-kourier-release-1.2-presubmits.yaml
- key openshift-knative-serving-release-v1.2.0-postsubmits.yaml using file ci-operator/jobs/openshift/knative-serving/openshift-knative-serving-release-v1.2.0-postsubmits.yaml
- key openshift-knative-serving-release-v1.2.0-presubmits.yaml using file ci-operator/jobs/openshift/knative-serving/openshift-knative-serving-release-v1.2.0-presubmits.yaml

Details

In response to this:

As per title, needed for Serverless 1.23.

/cc @nak3 @rhuss

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

skonto commented Apr 4, 2022

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022

openshift-ci Bot requested review from alanfx and mgencur April 4, 2022 11:26

skonto changed the title ~~Run CI for 1.2.0 serving, net-istio and net-kourier release~~ [wip] Run CI for 1.2.0 serving, net-istio and net-kourier release Apr 4, 2022

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2022

skonto changed the title ~~[wip] Run CI for 1.2.0 serving, net-istio and net-kourier release~~ Run CI for 1.2.0 serving, net-istio and net-kourier release Apr 4, 2022

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2022

skonto changed the title ~~Run CI for 1.2.0 serving, net-istio and net-kourier release~~ [wip] Run CI for 1.2.0 serving, net-istio and net-kourier release Apr 4, 2022

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2022

skonto changed the title ~~[wip] Run CI for 1.2.0 serving, net-istio and net-kourier release~~ WIP Run CI for 1.2.0 serving, net-istio and net-kourier release Apr 4, 2022

Run CI for 1.2.0 serving, net-istio and net-kourier release

bee91ca

skonto force-pushed the bump-serving-1.2.0 branch from a878e84 to bee91ca Compare April 7, 2022 13:31

make jobs

9a743e4

skonto mentioned this pull request Apr 7, 2022

Bump to 1.23 openshift-knative/serverless-operator#1479

Merged

matzew reviewed Apr 7, 2022

View reviewed changes

align golang versions in net-* config

65a893b

skonto changed the title ~~WIP Run CI for 1.2.0 serving, net-istio and net-kourier release~~ Run CI for 1.2.0 serving, net-istio and net-kourier release Apr 7, 2022

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2022

openshift-ci Bot assigned nak3 Apr 8, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022

openshift-merge-robot merged commit b86648f into openshift:master Apr 8, 2022

Conversation

skonto commented Apr 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skonto Apr 4, 2022

Choose a reason for hiding this comment

Uh oh!

matzew Apr 7, 2022

Choose a reason for hiding this comment

Uh oh!

skonto Apr 7, 2022

Choose a reason for hiding this comment

Uh oh!

skonto commented Apr 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skonto commented Apr 4, 2022

Uh oh!

skonto commented Apr 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skonto commented Apr 5, 2022

Uh oh!

skonto commented Apr 7, 2022

Uh oh!

skonto commented Apr 7, 2022

Uh oh!

matzew Apr 7, 2022

Choose a reason for hiding this comment

Uh oh!

skonto Apr 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skonto Apr 7, 2022

Choose a reason for hiding this comment

Uh oh!

skonto Apr 7, 2022

Choose a reason for hiding this comment

Uh oh!

skonto commented Apr 7, 2022

Uh oh!

skonto commented Apr 7, 2022

Uh oh!

skonto commented Apr 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skonto commented Apr 7, 2022

Uh oh!

skonto commented Apr 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nak3 commented Apr 8, 2022

Uh oh!

openshift-ci Bot commented Apr 8, 2022

Uh oh!

openshift-ci Bot commented Apr 8, 2022

Uh oh!

openshift-ci Bot commented Apr 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

skonto commented Apr 4, 2022 •

edited

Loading

skonto commented Apr 4, 2022 •

edited

Loading

skonto commented Apr 4, 2022 •

edited

Loading

skonto Apr 7, 2022 •

edited

Loading

skonto commented Apr 7, 2022 •

edited

Loading

skonto commented Apr 7, 2022 •

edited

Loading