Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

🤖 Triggering CI on branch 'release-next' after synching to upstream/main#1037

Merged
serverless-qe merged 1 commit into
release-nextfrom
release-next-ci
Feb 3, 2022
Merged

🤖 Triggering CI on branch 'release-next' after synching to upstream/main#1037
serverless-qe merged 1 commit into
release-nextfrom
release-next-ci

Conversation

@serverless-qe
Copy link
Copy Markdown

No description provided.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 26, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: serverless-qe
To complete the pull request process, please assign skonto after the PR has been reviewed.
You can assign the PR to them by writing /assign @skonto in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested a review from mvinkler January 26, 2022 00:37
@nak3
Copy link
Copy Markdown

nak3 commented Jan 26, 2022

knative#12548 changed the API version of PodDisruptionBudget. We need to backport it for the older versions.

    - lastTransitionTime: "2022-01-26T01:26:05Z"
      message: 'Install failed with message: no matches for kind "PodDisruptionBudget"
        in version "policy/v1"'

@nak3
Copy link
Copy Markdown

nak3 commented Jan 26, 2022

PDB will be removed on k8s 1.25 - https://kubernetes.io/docs/reference/using-api/deprecation-guide/#poddisruptionbudget-v125
So we should be able to use v1beta1 until OCP 4.12.

@skonto
Copy link
Copy Markdown

skonto commented Jan 31, 2022

/retest

@skonto
Copy link
Copy Markdown

skonto commented Jan 31, 2022

Still fails at the knative operator side:

{"severity":"ERROR","timestamp":"2022-01-31T12:19:45.675494917Z","logger":"knative-operator","caller":"controller/controller.go:566","message":"Reconcile error","knative.dev/pod":"knative-operator-f85548fd7-2s6xh","knative.dev/controller":"knative.dev.operator.pkg.reconciler.knativeserving.Reconciler","knative.dev/kind":"operator.knative.dev.KnativeServing","knative.dev/traceid":"60ff9774-c3e4-4282-abd9-53e0564b9fe1","knative.dev/key":"knative-serving/knative-serving","duration":"10.364026099s","error":"failed to apply non rbac manifest: no matches for kind \"PodDisruptionBudget\" in version \"policy/v1\"","stacktrace":"knative.dev/pkg/controller.(*Impl).handleErr\n\t/go/src/github.com/openshift-knative/serverless-operator/vendor/knative.dev/pkg/controller/controller.go:566\nknative.dev/pkg/controller.(*Impl).processNextWorkItem\n\t/go/src/github.com/openshift-knative/serverless-operator/vendor/knative.dev/pkg/controller/controller.go:543\nknative.dev/pkg/controller.(*Impl).RunContext.func3\n\t/go/src/github.com/openshift-knative/serverless-operator/vendor/knative.dev/pkg/controller/controller.go:478"}

@skonto
Copy link
Copy Markdown

skonto commented Jan 31, 2022

/retest

@skonto
Copy link
Copy Markdown

skonto commented Jan 31, 2022

Still fails because we install the latest via here.

@skonto
Copy link
Copy Markdown

skonto commented Feb 3, 2022

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 3, 2022

@serverless-qe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@serverless-qe
Copy link
Copy Markdown
Author

OCF Webhook is merging this PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants