Fix pdb

[skonto]

Right now there are failures in CI due to the wrong PDB version #1037. This was partially fixed in #1039.
Test that this patch works here: #1043

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhuss]

Makes sense to me, but let @mgencur give it a second look, please. I wonder how we can collect such "temporary hacks" in a central document so that we remind ourselves to clean those up when e.g. OCP 4.12 arrives ?

[skonto]

@rhuss I can add this to such a doc (preferably commit it in this repo) but also want to consult @nak3 when he gets back if there are more hacks to document.
In general it would be nice to cleanup any TODO stuff from time to time. I am sure there are such comments here and there in the code base and at least the less urgent ones are part of the technical debt.

[mgencur]

Looking at at update-to-head.sh script, it almost looks like this line should be moved after this line and then this little hack in tests would not be required. In other words: we already have the patch there so why not apply it before generating the knative-serving-ci.yaml ? I didn't try it but I think this should be the way to go.
Update: Moving the line there really propagates the patch into knative-serving-ci.yaml, tried that.

[skonto]

Ok I see what you mean. We generate the ci yaml file when we do the file resolution in generate-release.sh. Why we applied the patches later then if we need them in the openshift/release/knative-serving-${release}.yaml file? I guess it is because this is the first time we have a patch in config and we didnt care about when patches would be applied before. Ok let me update the PR.

[mgencur]

Yeah. Right, we need to apply the patch before calling generate-release.sh. I'm not sure why we had applying the patch later but it's probably the first time we're hitting this type of issue, as you mentioned.

[skonto]

@mgencur ready for review.

[mgencur]

Looks good to me. Merging

[mgencur]

Thanks!