[WIP] [TEST-ONLY] Fix pbd#1041
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
74649a8 to
284b38e
Compare
284b38e to
7fd551c
Compare
|
Hmm, I don't see any change in this PR that would make any difference. The patch is not applied here in a different order. Just my two cents. |
|
@mgencur I am in the process of applying the change :) |
|
Sorry, was too quick :) |
|
@skonto: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
AFAIK, the update-to-head.sh script is not running in this PR. In order to test it, you'll probably need to include the call to this script, exclude pushing to release-next-ci but rather create your own PR with the result and run it against release-next. |
|
@mgencur it seems so. Do you mean I should create a PR against release-next with only the change in file |
|
@skonto personally, I'd run the update-to-head script locally but commented out everything after this line https://github.com/openshift/knative-serving/blob/main/openshift/release/update-to-head.sh#L24 . And then I'd send a PR with the result against release-next. |
|
Ok you mean to emulate the patching that is happening elsewhere ok. Yeah ok I am not aware of all the details of the ci here thanks for your patience. |
|
closing this. |
Test if last commit fixes failures in #1037