Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

[WIP] [TEST-ONLY] Fix pbd#1041

Closed
skonto wants to merge 3 commits into
openshift:release-nextfrom
skonto:fix_pbd
Closed

[WIP] [TEST-ONLY] Fix pbd#1041
skonto wants to merge 3 commits into
openshift:release-nextfrom
skonto:fix_pbd

Conversation

@skonto
Copy link
Copy Markdown

@skonto skonto commented Jan 31, 2022

Test if last commit fixes failures in #1037

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2022
@openshift-ci openshift-ci Bot requested review from mgencur and rhuss January 31, 2022 21:12
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2022
@skonto skonto removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2022
@skonto skonto removed request for mgencur and rhuss January 31, 2022 21:14
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2022
@skonto skonto mentioned this pull request Feb 1, 2022
@openshift-ci openshift-ci Bot added area/test-and-release Issues or PRs related to test and release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 2, 2022
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2022
@mgencur
Copy link
Copy Markdown

mgencur commented Feb 2, 2022

Hmm, I don't see any change in this PR that would make any difference. The patch is not applied here in a different order. Just my two cents.

@skonto
Copy link
Copy Markdown
Author

skonto commented Feb 2, 2022

@mgencur I am in the process of applying the change :)

@mgencur
Copy link
Copy Markdown

mgencur commented Feb 2, 2022

Sorry, was too quick :)

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 2, 2022

@skonto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.7-e2e-aws-ocp-47 285b4ce link true /test 4.7-e2e-aws-ocp-47
ci/prow/4.6-e2e-aws-ocp-46 285b4ce link true /test 4.6-e2e-aws-ocp-46

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mgencur
Copy link
Copy Markdown

mgencur commented Feb 2, 2022

AFAIK, the update-to-head.sh script is not running in this PR. In order to test it, you'll probably need to include the call to this script, exclude pushing to release-next-ci but rather create your own PR with the result and run it against release-next.

@skonto
Copy link
Copy Markdown
Author

skonto commented Feb 2, 2022

@mgencur it seems so. Do you mean I should create a PR against release-next with only the change in file openshift/release/update-to-head.sh?

@mgencur
Copy link
Copy Markdown

mgencur commented Feb 2, 2022

@skonto personally, I'd run the update-to-head script locally but commented out everything after this line https://github.com/openshift/knative-serving/blob/main/openshift/release/update-to-head.sh#L24 . And then I'd send a PR with the result against release-next.

@skonto
Copy link
Copy Markdown
Author

skonto commented Feb 2, 2022

Ok you mean to emulate the patching that is happening elsewhere ok. Yeah ok I am not aware of all the details of the ci here thanks for your patience.

@skonto
Copy link
Copy Markdown
Author

skonto commented Feb 2, 2022

closing this.

@skonto skonto closed this Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Issues or PRs related to test and release do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants