[release-1.22] Override version migration images#1594
Conversation
|
Hitting https://bugzilla.redhat.com/show_bug.cgi?id=2087767 when using the internal registry. The Knative Kafka pods don't have the right pull secrets in time when they're created. |
mgencur
force-pushed
the
override_version_migration_images
branch
from
e508a17 to
1208e77
Compare
|
/retest |
|
/test 4.10-upgrade-tests-aws-ocp-410 |
1 similar comment
|
/test 4.10-upgrade-tests-aws-ocp-410 |
|
The previous runs show correct functionality: I will now remove the "revert" and tests should pass on all platforms now. |
mgencur
force-pushed
the
override_version_migration_images
branch
from
1208e77 to
a851710
Compare
mgencur
changed the title
|
The single failure doesn't look related. |
|
@mgencur what's the status here? |
|
@matzew Ready for review/merge. |
| # Get all storage version migration images. | ||
| while IFS=$'\n' read -r line; do | ||
| images+=("$line"); | ||
| done < <(grep storage-version-migration "$csv" | grep "image:" | awk '{ print $2 }' | awk -F"\"" '{ print $2 }') |
There was a problem hiding this comment.
for eventing-kafka-broker, we use an additional pattern for an additional post-install job
while reviewing this PR, I found that we are not mirroring these images yet (fixed in openshift/release#29177) so if we want to do this for the next release branches only, that's fine too.
There was a problem hiding this comment.
I did not include this pod/job in the checks because we haven't had problems with it, it already contains the product version, not upstream component versions (see below 1.23.0). So for each release the name will be different:
pod/kafka-controller-post-install-1.23.0--1-6vc5z
So, I think it's not necessary to include it. But let me know if you really want it to be added.
|
/test 4.10-upstream-e2e-aws-ocp-410 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pierDipi thanks for review! I will send that to 1.23 and main as well. |
4 participants
Fixes https://issues.redhat.com/browse/SRVCOM-1875
I'd send the same against main and release-1.23 when this PR is merged.
Proposed Changes