Skip to content

Override version migration images#1605

Merged
openshift-merge-robot merged 1 commit into
openshift-knative:mainfrom
mgencur:override_version_migration_images_main
Jun 9, 2022
Merged

Override version migration images#1605
openshift-merge-robot merged 1 commit into
openshift-knative:mainfrom
mgencur:override_version_migration_images_main

Conversation

@mgencur
Copy link
Copy Markdown
Contributor

@mgencur mgencur commented Jun 7, 2022

Same as #1594 , applying the same for main branch.

@openshift-ci openshift-ci Bot requested review from alanfx and aliok June 7, 2022 08:05
@openshift-ci openshift-ci Bot added the approved label Jun 7, 2022
@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented Jun 7, 2022

/cherrypick release-1.23

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.23 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented Jun 7, 2022

/assign @pierDipi

Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
unhold once tests are green.

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Jun 7, 2022

09:19:34.295 DEBUG:   [[ $(oc get pods -n knative-serving --field-selector=status.phase!=Succeeded -o jsonpath='{.items}') != '[]' ]] : Waiting until non-zero (max 600 sec.)
.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
09:31:23.890 ERROR:   Time out of 600 exceeded
09:31:23.891 ERROR:   🚨 Error (code: 71) occurred at ./hack/lib/serverless.bash:23, with command: return 71
09:31:23.894 ERROR:   Stack trace:
09:31:23.895 ERROR:    1: ./hack/teardown.sh:10 teardown_serverless(...)

/test 4.10-operator-e2e-aws-ocp-410

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Jun 7, 2022

/retest

@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented Jun 7, 2022

@pierDipi It's a real problem:

"message": "Back-off pulling image \"quay.io/openshift-knative/knative-serving-storage-version-migration:v1.3.0\"",

Looks like the image is not availble yet, I can pull v1.2.0 though.

@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented Jun 7, 2022

OK. The image mirroring is not yet set up for Serving/Eventing 1.3.x: https://github.com/openshift/release/blob/master/core-services/image-mirroring/knative/mapping_knative_v1_3_quay (only test images there)

@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented Jun 9, 2022

@pierDipi Sent openshift/release#29300 to unblock this PR. It's a short one, can you review please?

@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented Jun 9, 2022

Images have been mirrored.

/retest

@mgencur
Copy link
Copy Markdown
Contributor Author

mgencur commented Jun 9, 2022

/unhold

Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@mgencur: new pull request created: #1618

Details

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skonto skonto mentioned this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants