Skip to content

Bump manifests for serving core to 1.3.0#1598

Merged
openshift-merge-robot merged 1 commit into
openshift-knative:mainfrom
skonto:bump_manifests_serving_1.3.0
Jun 3, 2022
Merged

Bump manifests for serving core to 1.3.0#1598
openshift-merge-robot merged 1 commit into
openshift-knative:mainfrom
skonto:bump_manifests_serving_1.3.0

Conversation

@skonto
Copy link
Copy Markdown
Collaborator

@skonto skonto commented Jun 1, 2022 •
edited
Loading

Proposed Changes

  • The usual bumping for Serving.
  • Serving is actually on 1.3.2, compare commits here and here but for images we use 1.3.0 as a fixed namespace. Also manifests havent changed between minor versions.
  • In the future manifests will be fetched from the midstream repo instead of downloading from upstream, but let's stabilize for 1.24 before migrating to that.

@openshift-ci openshift-ci Bot requested review from jcrossley3 and lberk June 1, 2022 12:05
@openshift-ci openshift-ci Bot added the approved label Jun 1, 2022
skonto
skonto commented Jun 1, 2022
View reviewed changes
Comment thread olm-catalog/serverless-operator/manifests/serverless-operator.clusterserviceversion.yaml Outdated
value: "/var/run/ko/monitoring/rbac-proxy.yaml"
- name: "IMAGE_queue-proxy"
value: "registry.ci.openshift.org/openshift/knative-v1.2.0:knative-serving-queue"
value: "registry.ci.openshift.org/openshift/knative-v1.3.2:knative-serving-queue"
Copy link
Copy Markdown
Collaborator Author

@skonto skonto Jun 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images are not built yet. See the linked PRs that need to get merged first.

Copy link
Copy Markdown
Member

@matzew matzew Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skonto they are versioned as 1.3.0 - see: https://github.com/openshift/release/blob/master/ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-v1.3__410.yaml#L223

Copy link
Copy Markdown
Member

@matzew matzew Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you forced pushed the commit and updated to 1.3.0

yes, those are available and I can docker pull 'em

This was referenced Jun 1, 2022
Merged
Merged
Closed
Merged
@skonto skonto changed the title [wip] Bump manifests for serving core to 1.3.x Bump manifests for serving core to 1.3.x Jun 2, 2022
@skonto skonto changed the title Bump manifests for serving core to 1.3.x Bump manifests for serving core to 1.3.0 Jun 2, 2022
@skonto skonto requested review from matzew, mgencur and nak3 and removed request for jcrossley3 and lberk June 2, 2022 09:18
@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jun 2, 2022

/retest

@nak3
Copy link
Copy Markdown
Contributor

nak3 commented Jun 2, 2022

/lgtm
/hold

/hold for CI.

@openshift-ci openshift-ci Bot added the lgtm label Jun 2, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jun 2, 2022

/retest

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jun 2, 2022 

Failed to pull image "quay.io/openshift-knative/kafka-consumer:v1.3": rpc error: code = Unknown desc = reading manifest v1.3 in quay.io/openshift-knative/kafka-consumer: manifest unknown: manifest unknown

Let's poke CI for Eventing on that branch.

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jun 2, 2022 •
edited
Loading

Image is now available. Docker pull works. Retesting. Fixed via openshift/release#29100.

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jun 2, 2022

/retest

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jun 2, 2022 •
edited
Loading

Tests pass @nak3 we can unhold

@nak3
Copy link
Copy Markdown
Contributor

nak3 commented Jun 3, 2022

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit 7205c11 into openshift-knative:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nak3 nak3 Awaiting requested review from nak3

@mgencur mgencur Awaiting requested review from mgencur

@matzew matzew Awaiting requested review from matzew

Assignees

@nak3 nak3

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skonto @nak3 @matzew @openshift-merge-robot