Use Serving 1.3.2 instead of 1.3.0

[skonto]

• We use 1.3.2 and generate manifests for that here: Bump manifests for serving core to 1.3.0 openshift-knative/serverless-operator#1598, so let's be accurate for that part so that generated images are available.

[skonto]

/cc @mgencur @nak3

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/knative-serving/OWNERS [skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nak3]

Why you need to use 1.3.2 instead of 1.3.0? You just want to align the number?

If upstream release 1.3.3 in the future, you will bump the image tag again?

[skonto]

If upstream release 1.3.3 in the future, you will bump the image tag again?

@nak3 I wanted to download the latest manifests.
I dont feel it is going to be any we are moving to 1.5 today. However, do you suggest to leave it as 1.3.0 and use the manifest for 1.3.0 anyway? I dont want to hardcode anything here but I could fix the S_O to pick up another namespace for the Serving images instead of using the Serving version in project.yaml.
WDYTH? Then we could keep 1.3.0 forever and we download the right manifests version.
At some point we will get the manifests from the midstream repo anyway so this will be temporary. Goal is to avoid having to download them from upstream and then patch them(check what Eventing is doing here openshift-knative/serverless-operator#1591 which we will eventually folllow).
Could you merge the PRs that poke the CI in net-* and serving repos? We have no images for the 1.{3,4} releases.

[openshift-ci]

@skonto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/pj-rehearse	16a9987	link	false	/test pj-rehearse
ci/rehearse/openshift/knative-serving/release-v1.3/47-e2e-aws-ocp-47	16a9987	link	unknown	/test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[nak3]

I dont feel it is going to be any we are moving to 1.5 today. However, do you suggest to leave it as 1.3.0 and use the manifest for 1.3.0 anyway? I dont want to hardcode anything here but I could fix the S_O to pick up another namespace for the Serving images instead of using the Serving version in project.yaml.
WDYTH? Then we could keep 1.3.0 forever and we download the right manifests version.

In most cases, upstream does not change the manifest between the incremental release. So, I don't see any issue we use 1.3.0 manifest because we replace the image. What problem you are concerned?

At some point we will get the manifests from the midstream repo anyway so this will be temporary so we dont have to download them from upstream and then patch them(check what Eventing is doing here openshift-knative/serverless-operator#1591 which we will eventually folllow).

Well... They use 1.3.2 instead of the latest tag 1.3.3 https://github.com/knative/eventing/releases/tag/knative-v1.3.3
Sorry for my repeat but if upstream release 1.3.3 in the future, you will bump the image tag as well?

[skonto]

Sorry for my repeat but if upstream release 1.3.3 in the future, you will bump the image tag as well?

Probably I dont see much of an issue.

In most cases, upstream does not change the manifest between the incremental release. So, I don't see any issue we use 1.3.0 manifest because we replace the image. What problem you are concerned?

In most cases true just trying to make sure I dont hit a corner case anyway. I dont want to think about releases and diffs.
Anyway falling back to 1.3.0 let's make sure we have the images built. :)

[skonto]

Closing this will use 1.3.0.