Skip to content

Allow injecting Knative Eventing images in CSV#1591

Merged
openshift-merge-robot merged 8 commits into
openshift-knative:mainfrom
pierDipi:replace-eventing-images
Jun 7, 2022
Merged

Allow injecting Knative Eventing images in CSV#1591
openshift-merge-robot merged 8 commits into
openshift-knative:mainfrom
pierDipi:replace-eventing-images

Conversation

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi pierDipi commented May 30, 2022 •
edited
Loading

As discussed in the SIG release call, this allows running eventing
midstream tests by using the serverless operator.

Proposed Changes

  • Allow injecting Knative Eventing images in CSV

@openshift-ci openshift-ci Bot requested review from aliok and lberk May 30, 2022 14:35
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented May 30, 2022

Testing this PR in openshift-knative/eventing-kafka-broker#286

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented May 30, 2022

/test 4.10-upgrade-tests-aws-ocp-410

@pierDipi pierDipi force-pushed the replace-eventing-images branch from fa2f78d to 1caf387 Compare May 31, 2022 10:43
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented May 31, 2022

/test 4.10-upgrade-tests-aws-ocp-410

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented May 31, 2022

panic: test timed out after 1h30m0s
/test 4.10-upgrade-tests-aws-ocp-410

@pierDipi pierDipi force-pushed the replace-eventing-images branch from 1caf387 to 09b30fa Compare June 1, 2022 13:25
@skonto skonto mentioned this pull request Jun 1, 2022
Closed
@pierDipi pierDipi mentioned this pull request Jun 1, 2022
Merged
@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 2, 2022

/test 4.10-upstream-e2e-mesh-aws-ocp-410

matzew
matzew reviewed Jun 2, 2022
View reviewed changes
Comment thread openshift-knative-operator/hack/update-manifests.sh Outdated
target_file="$target_dir/$index-$file"
if [[ ${KNATIVE_EVENTING_MANIFESTS_DIR} = "" ]]; then
branch=$(metadata.get dependencies.eventing_artifacts_branch)
url="https://raw.githubusercontent.com/openshift/eventing/${branch}/openshift/release/artifacts/$file"
Copy link
Copy Markdown
Member

@matzew matzew Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://raw.githubusercontent.com/openshift/eventing

it should be knative-eventing

pierDipi added 8 commits June 6, 2022 10:19
@pierDipi
Allow injecting Knative Eventing images in CSV
053aa3a 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Allow overriding Kafka artifacts
c09c39b 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Allow overriding eventing core images
401992c 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Use midstream artifacts for eventing
d06cff8 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Remove patches from SO and move them to midstream
edbc6ef 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Bump eventing core to 1.3.2
dea281c 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Add install-tracing target
389e9f6 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Use correct midstream repository
7ebe642 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the replace-eventing-images branch from 09b30fa to 7ebe642 Compare June 6, 2022 08:20
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jun 6, 2022

/test 4.10-upgrade-tests-aws-ocp-410

2 similar comments
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jun 6, 2022

/test 4.10-upgrade-tests-aws-ocp-410

@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 7, 2022

/test 4.10-upgrade-tests-aws-ocp-410

@pierDipi pierDipi changed the title [WIP] Allow injecting Knative Eventing images in CSV Allow injecting Knative Eventing images in CSV Jun 7, 2022
matzew
matzew approved these changes Jun 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Jun 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jun 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit de52a1f into openshift-knative:main Jun 7, 2022
@pierDipi pierDipi deleted the replace-eventing-images branch June 7, 2022 08:50
@pierDipi pierDipi restored the replace-eventing-images branch June 7, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

@lberk lberk Awaiting requested review from lberk

Assignees

@matzew matzew

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierDipi @matzew @openshift-merge-robot