Run tests by using serverless operator by pierDipi · Pull Request #1752 · openshift/knative-eventing

pierDipi · 2022-05-30T17:43:33Z

No description provided.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi · 2022-05-31T07:44:07Z

/retest

pierDipi · 2022-05-31T08:14:51Z

/retest

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi · 2022-05-31T08:39:43Z

Notes:

tracing tests failing in https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_knative-eventing/1752/pull-ci-openshift-knative-eventing-release-v1.3-410-conformance-aws-ocp-410/1531530437896179712
various error: error copying source path /go/bin/controller to .: exit status 1 or error: error copying source path /go/bin/recordevents to .: exit status 1

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

matzew · 2022-05-31T09:52:34Z

+eventing_core="${artifacts_dir}/eventing-core.yaml"
+eventing_crds="${artifacts_dir}/eventing-crds.yaml"
+in_memory_channel="${artifacts_dir}/in-memory-channel.yaml"
+mt_channel_broker="${artifacts_dir}/mt-channel-broker.yaml"
+eventing_sugar_controller="${artifacts_dir}/eventing-sugar-controller.yaml"
+eventing_post_install="${artifacts_dir}/eventing-post-install.yaml"


I like the alignment w/ the upstream manifests

matzew · 2022-05-31T10:13:40Z

    sed -e "s+\(.* image: \)\(knative.dev\)\(.*/\)\(test/\)\(.*\)+\1\2 \3\4test-\5+g" \
        -e "s+ko://++" \
        -e "s+eventing.knative.dev/release: devel+eventing.knative.dev/release: ${release}+" \
+        -e "s+app.kubernetes.io/version: devel+app.kubernetes.io/version: ${release}+" \


+1 nice catch

matzew · 2022-05-31T10:14:41Z

    app.kubernetes.io/version: devel
    app.kubernetes.io/name: knative-eventing
 spec:
-  minAvailable: 80%


for release next - I think we should (not now 😉 ) move those to an actual patch, so we have these tehere too - much more relevant with this thna before

it's there https://github.com/openshift/knative-eventing/blob/aa45339d9e7e0cb80a9566257f0760a434c707e6/openshift/patches/024-webhook-pdb.patch

pierDipi · 2022-05-31T10:28:20Z

/retest

pierDipi · 2022-05-31T10:31:18Z

/test 48-e2e-aws-ocp-48

pierDipi · 2022-05-31T11:05:18Z

/retest

pierDipi · 2022-05-31T12:48:33Z

/retest

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi · 2022-06-01T09:34:13Z

/retest

pierDipi · 2022-06-01T11:18:38Z

/retest

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

matzew · 2022-06-01T14:56:07Z

/retest

pierDipi · 2022-06-01T15:05:47Z

Capturing some notes:

there is this error which needs a fix:
storage-version-migration-eventing-eventing-1.2.1-sp8l6 0/1 InvalidImageName 0 6m7s

some other test is failing with:

11:23:52.476 INFO:    Create namespaces
Unable to connect to the server: dial tcp: lookup api.ci-ocp-4-9-amd64-aws-us-west-1-px66v.hive.aws.ci.openshift.org on 172.30.0.10:53: no such host

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

matzew · 2022-06-01T15:37:11Z

+kind: Role
+metadata:
+  namespace: knative-eventing
+  name: openshift-serverless-view-eventing-configmaps


where does this come from?

From this https://github.com/openshift-knative/serverless-operator/blob/main/openshift-knative-operator/hack/002-openshift-eventing-role.patch

why do we need to vendor this, than? we we just want to replace the images?

I'm not following, where is the vendor involved here?

matzew · 2022-06-01T15:39:23Z

-  cat openshift/release/knative-eventing-ci.yaml > ci
-  cat openshift/release/knative-eventing-mtbroker-ci.yaml >> ci
+  local operator_dir=/tmp/serverless-operator
+  git clone --branch replace-eventing-images https://github.com/pierDipi/serverless-operator.git $operator_dir


we use this branch (really ok to do so - no worry), so that we inject the right images, than being able to do make generated-files, right?

correct!

this branch matches up with PR openshift-knative/serverless-operator#1591

So... locally, this PR (with the referenced SO pr) works fine

pierDipi · 2022-06-06T08:22:03Z

/retest

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi · 2022-06-06T11:12:19Z

/retest

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi · 2022-06-06T19:32:24Z

/retest

pierDipi · 2022-06-07T05:18:05Z

/retest

pierDipi · 2022-06-07T05:35:59Z

/test 49-e2e-aws-ocp-49

pierDipi · 2022-06-07T05:53:24Z

/retest

openshift-ci · 2022-06-07T07:02:35Z

@pierDipi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

matzew

/lgtm
/approve

openshift-ci · 2022-06-07T07:18:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [matzew,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierDipi added 2 commits May 30, 2022 19:35

Delete bundled artifacts

a073a2d

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Update generate release to have matching upstream files

c25d5bb

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2022

openshift-ci Bot requested review from aliok and lberk May 30, 2022 17:44

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2022

pierDipi force-pushed the test-via-SO branch from 34d2c68 to cd75341 Compare May 30, 2022 17:44

Run make generate-release RELEASE=v1.3.2

52d3ab0

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi force-pushed the test-via-SO branch from cd75341 to 52d3ab0 Compare May 30, 2022 17:46

pierDipi added 2 commits May 30, 2022 21:56

Set explicit GOPATH

bf22eb1

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Move patches from SO to here

8c92b63

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi force-pushed the test-via-SO branch from a20ac0d to 8c92b63 Compare May 31, 2022 06:57

Remove GitHub workflows

865341f

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Install tracing

aa45339

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

matzew reviewed May 31, 2022

View reviewed changes

Use target to install tracing

ec985ea

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi closed this Jun 1, 2022

pierDipi reopened this Jun 1, 2022

Cat CSV for auditing it

b61ecb5

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Remove replace commands since those are manage by the operator

fa9f36a

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

matzew reviewed Jun 1, 2022

View reviewed changes

pierDipi added 2 commits June 6, 2022 10:25

Use repository-related paths

48f9543

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Enable tracing

4155a3c

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Zipkin beckend is required by eventing tests (hardcoded in tests)

6718f2d

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

matzew approved these changes Jun 7, 2022

View reviewed changes

openshift-ci Bot assigned matzew Jun 7, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2022

pierDipi changed the title ~~[WIP] Run tests by using serverless operator~~ Run tests by using serverless operator Jun 7, 2022

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2022

openshift-merge-robot merged commit 98d790b into openshift:release-v1.3 Jun 7, 2022

pierDipi deleted the test-via-SO branch June 7, 2022 08:28

This was referenced Jul 26, 2022

[release-v1.4] Run tests by using serverless operator #1822

Merged

[release-v1.5] Run tests by using serverless operator #1823

Merged

Conversation

pierDipi commented May 30, 2022

Uh oh!

pierDipi commented May 31, 2022

Uh oh!

pierDipi commented May 31, 2022

Uh oh!

pierDipi commented May 31, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pierDipi commented May 31, 2022

Uh oh!

pierDipi commented May 31, 2022

Uh oh!

pierDipi commented May 31, 2022

Uh oh!

pierDipi commented May 31, 2022

Uh oh!

pierDipi commented Jun 1, 2022

Uh oh!

pierDipi commented Jun 1, 2022

Uh oh!

matzew commented Jun 1, 2022

Uh oh!

pierDipi commented Jun 1, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pierDipi commented Jun 6, 2022

Uh oh!

pierDipi commented Jun 6, 2022

Uh oh!

pierDipi commented Jun 6, 2022

Uh oh!

pierDipi commented Jun 7, 2022

Uh oh!

pierDipi commented Jun 7, 2022

Uh oh!

pierDipi commented Jun 7, 2022

Uh oh!

openshift-ci Bot commented Jun 7, 2022

Uh oh!

matzew left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jun 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants