Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

[release-v1.4] Run tests by using serverless operator#1822

Merged
openshift-merge-robot merged 4 commits into
openshift:release-v1.4from
pierDipi:run-tests-using-SO-v1.4
Aug 2, 2022
Merged

[release-v1.4] Run tests by using serverless operator#1822
openshift-merge-robot merged 4 commits into
openshift:release-v1.4from
pierDipi:run-tests-using-SO-v1.4

Conversation

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi pierDipi commented Jul 26, 2022

Like #1752 but for release-v1.4 branch

@pierDipi
Run tests using SO
07bff22 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jul 26, 2022

/cc @aliok

@openshift-ci openshift-ci Bot requested review from aliok, lberk and matzew July 26, 2022 08:16
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jul 26, 2022

blocked by openshift-knative/serverless-operator#1658

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jul 26, 2022

/retest-required

@pierDipi
Use on cluster builds for SO images
1338459 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the run-tests-using-SO-v1.4 branch from 1f4b07c to 1338459 Compare July 29, 2022 15:27
@pierDipi pierDipi mentioned this pull request Aug 1, 2022
Merged
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Aug 1, 2022

Fix in openshift-knative/serverless-operator#1663

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Aug 1, 2022

/retest

@pierDipi
Fix manifest consistency check
14189a1 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Aug 1, 2022

/retest

@pierDipi
install_serverless is enough to install Eventing
f053655 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Aug 2, 2022

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 2, 2022

@pierDipi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

matzew
matzew approved these changes Aug 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@matzew
Copy link
Copy Markdown
Member

matzew commented Aug 2, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 994d584 into openshift:release-v1.4 Aug 2, 2022
@pierDipi pierDipi deleted the run-tests-using-SO-v1.4 branch August 2, 2022 13:56
@pierDipi pierDipi mentioned this pull request Aug 3, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aliok aliok Awaiting requested review from aliok

@lberk lberk Awaiting requested review from lberk

1 more reviewer

@matzew matzew matzew approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierDipi @matzew @openshift-merge-robot