Skip to content

[SRVKE-1192] Remove sugar-controller#1658

Merged
openshift-merge-robot merged 1 commit into
openshift-knative:mainfrom
pierDipi:SRVKE-1192_Remove-sugar-controller
Jul 26, 2022
Merged

[SRVKE-1192] Remove sugar-controller#1658
openshift-merge-robot merged 1 commit into
openshift-knative:mainfrom
pierDipi:SRVKE-1192_Remove-sugar-controller

Conversation

@pierDipi
Copy link
Copy Markdown
Member

sugar-controller is no longer a separate deployment in 1.24.

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@openshift-ci openshift-ci Bot requested review from dsimansk and matzew July 26, 2022 09:08
@pierDipi pierDipi changed the title [WIP][SRVKE-1192] Remove sugar-controller [SRVKE-1192] Remove sugar-controller Jul 26, 2022
@pierDipi
Copy link
Copy Markdown
Member Author

/assign @aliok

@pierDipi
Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@pierDipi
Copy link
Copy Markdown
Member Author

/retest

Copy link
Copy Markdown
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Jul 26, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 26, 2022

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.10-upstream-e2e-aws-ocp-410 d8926de link false /test 4.10-upstream-e2e-aws-ocp-410
ci/prow/4.10-upgrade-tests-aws-ocp-410 d8926de link false /test 4.10-upgrade-tests-aws-ocp-410
ci/prow/4.10-upstream-e2e-mesh-aws-ocp-410 d8926de link false /test 4.10-upstream-e2e-mesh-aws-ocp-410

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 2 against base HEAD 420b3a6 and 8 for PR HEAD d8926de in total

@openshift-merge-robot openshift-merge-robot merged commit 617072b into openshift-knative:main Jul 26, 2022
@pierDipi pierDipi deleted the SRVKE-1192_Remove-sugar-controller branch July 27, 2022 08:09
@pierDipi pierDipi restored the SRVKE-1192_Remove-sugar-controller branch February 19, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants