Skip to content

Use an amd64 tag for the opm image#1644

Merged
openshift-ci[bot] merged 1 commit into
openshift-knative:mainfrom
skonto:fix_opm_image
Jul 13, 2022
Merged

Use an amd64 tag for the opm image#1644
openshift-ci[bot] merged 1 commit into
openshift-knative:mainfrom
skonto:fix_opm_image

Conversation

@skonto
Copy link
Copy Markdown
Collaborator

@skonto skonto commented Jul 13, 2022 •
edited
Loading

Proposed Changes

  • Facing the issue here. Our jobs use amd64 afaik. The image changed a few hours ago and things broke.
  • opm:latest is derived from an arm64 arch check here.
  • Discussion on slack here.

@openshift-ci openshift-ci Bot requested review from alanfx and lberk July 13, 2022 08:06
@skonto skonto requested review from mgencur, pierDipi and rhuss and removed request for alanfx, lberk and rhuss July 13, 2022 08:07
@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jul 13, 2022 •
edited
Loading

Hitting it here too: #1642 in another form:

[1/2] STEP 4/5: RUN /bin/opm init serverless-operator --default-channel=stable --output yaml >> /configs/index.yaml
/bin/sh: /bin/opm: cannot execute binary file: Exec format error

@nak3 nak3 mentioned this pull request Jul 13, 2022
Merged
@skonto skonto requested a review from dsimansk July 13, 2022 08:21
pierDipi
pierDipi reviewed Jul 13, 2022
View reviewed changes
Comment thread olm-catalog/serverless-operator/index/Dockerfile Outdated
FROM openshift/origin-base as builder

COPY --from=quay.io/operator-framework/opm:latest /bin/opm /bin/opm
COPY --from=quay.io/operator-framework/opm:v1.23.2-amd64 /bin/opm /bin/opm
Copy link
Copy Markdown
Member

@pierDipi pierDipi Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:master is multi arch, can we use that one?

Copy link
Copy Markdown
Member

@pierDipi pierDipi Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or v1.23

Copy link
Copy Markdown
Collaborator Author

@skonto skonto Jul 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to use master? that tag is multi arch too. Let me ask again.

Copy link
Copy Markdown
Member

@pierDipi pierDipi Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.23.2-amd64 isn't v1.23 is multi arch

Copy link
Copy Markdown
Member

@pierDipi pierDipi Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to use master?

No, it's not but so far we have used "latest" which isn't safe as well

Copy link
Copy Markdown
Member

@pierDipi pierDipi Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with v1.23

Copy link
Copy Markdown
Collaborator Author

@skonto skonto Jul 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched to v1.23.2 now that some tests passed.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 13, 2022

@skonto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.10-upstream-e2e-aws-ocp-410 3eeab54 link false /test 4.10-upstream-e2e-aws-ocp-410

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jul 13, 2022

flacky test
/retest

pierDipi
pierDipi approved these changes Jul 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Jul 13, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot merged commit caf1098 into openshift-knative:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierDipi pierDipi pierDipi approved these changes

@mgencur mgencur Awaiting requested review from mgencur

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@pierDipi pierDipi

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skonto @pierDipi