Skip to content

Remove istio, kourier patches#1642

Merged
openshift-merge-robot merged 4 commits into
openshift-knative:mainfrom
skonto:override_env_via_injection_net
Jul 26, 2022
Merged

Remove istio, kourier patches#1642
openshift-merge-robot merged 4 commits into
openshift-knative:mainfrom
skonto:override_env_via_injection_net

Conversation

@skonto
Copy link
Copy Markdown
Collaborator

@skonto skonto commented Jul 11, 2022 •
edited
Loading

Proposed Changes

  • Part of the work for the SIG release
  • Removes the remaining bits
  • Moves manifests to the midstream repos

Pending:

  1. PR at serving/net-istio,kourier side
  2. ingress image injection

@openshift-ci openshift-ci Bot requested review from aliok and mgencur July 11, 2022 18:58
This was referenced Jul 12, 2022
Closed
Closed
Merged
@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jul 12, 2022

/retest

This was referenced Jul 13, 2022
Merged
Merged
This was referenced Jul 22, 2022
Merged
Merged
skonto
skonto commented Jul 25, 2022
View reviewed changes
Comment thread olm-catalog/serverless-operator/project.yaml Outdated

# versions for networking components
kourier: 1.4.0
net_kourier_artifacts_branch: override_env_via_injection_net_1.4
Copy link
Copy Markdown
Collaborator Author

@skonto skonto Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be replaced with release-1.4

This was referenced Jul 25, 2022
Merged
Merged
@skonto skonto changed the title [wip] Remove istio, kourier patches Remove istio, kourier patches Jul 25, 2022
@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jul 25, 2022

/hold let's get in first:
openshift-knative/net-kourier#27
openshift-knative/net-istio#14
so we can rename the artifact branches.

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jul 25, 2022

/unhold

@skonto skonto requested review from nak3 and pierDipi and removed request for mgencur July 25, 2022 14:25
@skonto skonto removed the request for review from aliok July 25, 2022 14:25
@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jul 25, 2022 

The connection to the server api.ci-ocp-4-10-amd64-aws-us-east-1-nvh9z.hive.aws.ci.openshift.org:6443 was refused - did you specify the right host or port?

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jul 25, 2022

/retest

1 similar comment
@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jul 25, 2022

/retest

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Jul 25, 2022

@nak3 gentle ping.

@nak3
Copy link
Copy Markdown
Contributor

nak3 commented Jul 26, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 26, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2ac1c4a into openshift-knative:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nak3 nak3 Awaiting requested review from nak3

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@nak3 nak3

@pierDipi pierDipi

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skonto @nak3 @openshift-merge-robot @pierDipi