Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

[RELEASE-v1.4] Support config to deploy internal certificates automatically (#13005)#1183

Merged
openshift-merge-robot merged 1 commit into
openshift:release-v1.4from
nak3:backport-e2e-encryption
Jul 29, 2022
Merged

[RELEASE-v1.4] Support config to deploy internal certificates automatically (#13005)#1183
openshift-merge-robot merged 1 commit into
openshift:release-v1.4from
nak3:backport-e2e-encryption

Conversation

@nak3
Copy link
Copy Markdown

@nak3 nak3 commented Jul 25, 2022

This patch cherry-pics knative@58cce54.

@openshift-ci openshift-ci Bot requested review from alanfx and mgencur July 25, 2022 08:27
@openshift-ci openshift-ci Bot added area/test-and-release Issues or PRs related to test and release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 25, 2022
@skonto
Copy link
Copy Markdown

skonto commented Jul 25, 2022 •
edited
Loading

@nak3 as a side note and independently of the failures above, I suspect for tests to run properly since we merged first #1173 we need to also merge openshift-knative/serverless-operator#1642. Ideally the latter needs to get in first.

@skonto
Copy link
Copy Markdown

skonto commented Jul 26, 2022

/retest

@nak3 nak3 force-pushed the backport-e2e-encryption branch from ea6abd6 to 45b71b9 Compare July 27, 2022 03:02
@nak3
Copy link
Copy Markdown
Author

nak3 commented Jul 27, 2022

/retest

@nak3 nak3 mentioned this pull request Jul 27, 2022
Closed
@nak3 nak3 force-pushed the backport-e2e-encryption branch from bc6e49f to b644881 Compare July 27, 2022 07:35
@nak3 @knative-automation
Support config to deploy internal certificates automatically (knative…
9b93484 
…#13005)

* Add certificate reconciler for internal certs

* Fix cert path

* Temporary use local networking repo

* Support internal-encryption configuration

* Use const for cert name

* Fix lint

* rm blank line

* Drop unused variable

* Use one line style

* Use one line code

* Update net-kourier nightly

bumping knative.dev/net-kourier d758682...b9b1e8b:
  > b9b1e8b Use `internal-encryption` to deploy internal certificates automatically (# 855)
  > 427434c bump kind and k8s versions in kind-e2e tests (# 859)

Signed-off-by: Knative Automation <automation@knative.team>

* Verify SecretPKKey as well

* Do not drop activator always in the path

* Comment about ctrl-ca suffix

Co-authored-by: Knative Automation <automation@knative.team>
@nak3 nak3 force-pushed the backport-e2e-encryption branch from 6eadb1a to 9b93484 Compare July 28, 2022 03:16
@skonto
Copy link
Copy Markdown

skonto commented Jul 28, 2022 

oc create configmap kourier-cm -n openshift-serverless --from-file=/tmp/kourier.yaml
error: failed to create configmap: namespaces "openshift-serverless" not found

/retest

@nak3
Copy link
Copy Markdown
Author

nak3 commented Jul 28, 2022

/test 49-e2e-aws-ocp-49

@nak3
Copy link
Copy Markdown
Author

nak3 commented Jul 28, 2022

@skonto This PR is ready to go now. Could you please take a look this and openshift-knative/net-kourier#23?

(#1188 also verified with enabling internal-encryption .)

@skonto
Copy link
Copy Markdown

skonto commented Jul 28, 2022 •
edited
Loading

Same error?

+ oc create namespace openshift-serverless
The connection to the server api.ci-ocp-4-9-amd64-aws-us-west-1-pv5gz.hive.aws.ci.openshift.org:6443 was refused - did you specify the right host or port?
....
++ oc get operatorgroups -oname -n openshift-serverless..
+ oc create configmap kourier-cm -n openshift-serverless --from-file=/tmp/kourier.yaml
error: failed to create configmap: namespaces "openshift-serverless" not found

@nak3
Copy link
Copy Markdown
Author

nak3 commented Jul 28, 2022

Yeah, I will look into it tomorrow.
Hmm.. why only 4.9...

@skonto
Copy link
Copy Markdown

skonto commented Jul 28, 2022

Creation of the ns failed earlier seems infra.

@nak3
Copy link
Copy Markdown
Author

nak3 commented Jul 28, 2022

Ah, you are right.

+ oc create namespace openshift-serverless
The connection to the server api.ci-ocp-4-9-amd64-aws-us-west-1-pv5gz.hive.aws.ci.openshift.org:6443 was refused - did you specify the right host or port?

@skonto
Copy link
Copy Markdown

skonto commented Jul 28, 2022 •
edited
Loading

@nak3 there is a file added: cmd/activator/.main.go.swp. I guess we need to remove it.

@nak3
Copy link
Copy Markdown
Author

nak3 commented Jul 28, 2022

No, I removed it. It was added by mistake on upstream and removed knative@92b11a8 .
I think we should remove it here too.

@skonto
Copy link
Copy Markdown

skonto commented Jul 28, 2022

Yes we should remove it its garbage.

@skonto
Copy link
Copy Markdown

skonto commented Jul 28, 2022

/test 49-e2e-aws-ocp-49

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 28, 2022

@nak3: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@skonto
Copy link
Copy Markdown

skonto commented Jul 29, 2022

@nak3 this seems ready. LGTM but can we remove the swp file?

@nak3
Copy link
Copy Markdown
Author

nak3 commented Jul 29, 2022

Nah, this PR is removing the swap file. It will be removed when you merged this PR.

@skonto
Copy link
Copy Markdown

skonto commented Jul 29, 2022 •
edited
Loading

Ok my bad misread the github sign. What about the order of merging should we do the S-O one first?

@nak3
Copy link
Copy Markdown
Author

nak3 commented Jul 29, 2022

Either is fine. So. I updated S-O for ready.

@skonto
Copy link
Copy Markdown

skonto commented Jul 29, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f32363b into openshift:release-v1.4 Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alanfx alanfx Awaiting requested review from alanfx

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@skonto skonto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Issues or PRs related to test and release lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nak3 @skonto @openshift-merge-robot