Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

[TEST_ONLY][RELEASE-v1.4] Backport e2e encryption enable encryption#1188

Closed
nak3 wants to merge 12 commits into
openshift:release-v1.4from
nak3:backport-e2e-encryption-enable-encryption
Closed

[TEST_ONLY][RELEASE-v1.4] Backport e2e encryption enable encryption#1188
nak3 wants to merge 12 commits into
openshift:release-v1.4from
nak3:backport-e2e-encryption-enable-encryption

Conversation

@nak3
Copy link
Copy Markdown

@nak3 nak3 commented Jul 27, 2022

#1183 is backporting the e2e encryption but not enabled the option.

This patch tries to run CI with internal-encryption turned on.

nak3 and others added 5 commits July 27, 2022 12:02
@nak3 @knative-automation
Support config to deploy internal certificates automatically (knative…
45b71b9 
…#13005)

* Add certificate reconciler for internal certs

* Fix cert path

* Temporary use local networking repo

* Support internal-encryption configuration

* Use const for cert name

* Fix lint

* rm blank line

* Drop unused variable

* Use one line style

* Use one line code

* Update net-kourier nightly

bumping knative.dev/net-kourier d758682...b9b1e8b:
  > b9b1e8b Use `internal-encryption` to deploy internal certificates automatically (# 855)
  > 427434c bump kind and k8s versions in kind-e2e tests (# 859)

Signed-off-by: Knative Automation <automation@knative.team>

* Verify SecretPKKey as well

* Do not drop activator always in the path

* Comment about ctrl-ca suffix

Co-authored-by: Knative Automation <automation@knative.team>
@nak3
Fix
0cbde6e
@nak3
fix
174660c
@nak3
Update e2e-common
88c97ff
@nak3
Drop activator restart
1d5a03c
@openshift-ci openshift-ci Bot requested review from alanfx and mgencur July 27, 2022 05:48
@openshift-ci openshift-ci Bot added the area/test-and-release Issues or PRs related to test and release label Jul 27, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@nak3 nak3 force-pushed the backport-e2e-encryption-enable-encryption branch from 3899d2f to afa6f3c Compare July 27, 2022 07:36
@nak3
Copy link
Copy Markdown
Author

nak3 commented Jul 28, 2022 •
edited
Loading

Failure of OCP 4.7~4.8 is expected as custom net-kourier which does not modify MIN_K8SVERSION 37b6c5e Using the built image from downstream repo now.

@nak3
Copy link
Copy Markdown
Author

nak3 commented Jul 28, 2022

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 28, 2022

@nak3: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nak3 nak3 mentioned this pull request Jul 28, 2022
Merged
skonto
skonto reviewed Jul 29, 2022
View reviewed changes
Comment thread openshift/e2e-common.sh
local SERVERLESS_DIR=$(mktemp -d)
local CURRENT_DIR=$(pwd)
git clone --depth 1 https://github.com/openshift-knative/serverless-operator.git ${SERVERLESS_DIR}
git clone -b support-passthrough --depth 1 https://github.com/nak3/serverless-operator.git ${SERVERLESS_DIR}
Copy link
Copy Markdown

@skonto skonto Jul 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to revert this I guess when S-O work is done?

Copy link
Copy Markdown
Author

@nak3 nak3 Jul 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct.
This PR has a lot of manual change so I will clean up it after
#1183 and S-O work were done.

Copy link
Copy Markdown
Author

@nak3 nak3 Jul 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case, I think we don't need to merge this (and you don't need to review this) until S-O was merged.
This PR just demonstrates that the backport with enabling option works fine.

Copy link
Copy Markdown

@skonto skonto Aug 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah ok

@nak3 nak3 closed this Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alanfx alanfx Awaiting requested review from alanfx

@mgencur mgencur Awaiting requested review from mgencur

1 more reviewer

@skonto skonto skonto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Issues or PRs related to test and release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nak3 @skonto