Add job GeneratedName transformer to eventing, serving by skonto · Pull Request #1648 · openshift-knative/serverless-operator

skonto · 2022-07-18T09:49:44Z

Proposed Changes

Even if we have a different release suffix for the job name in the next few releases let's create unique names per S-O version.
Hit a related issue here: Bump to 1.25 #1647

mgencur · 2022-07-18T10:35:46Z

/lgtm
/hold
(for tests)

skonto · 2022-07-18T11:26:31Z

Need to inject the CURRENT_VERSION. Tests fail without this.

skonto · 2022-07-18T13:21:57Z

/retest

pierDipi · 2022-07-18T13:33:50Z

Upgrade test job https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-knative_serverless-operator/1648/pull-ci-openshift-knative-serverless-operator-main-4.10-upgrade-tests-aws-ocp-410/1548992971242737664:

  verify_jobs.go:24: no jobs found in namespace knative-serving

skonto · 2022-07-18T13:53:08Z

Yes I saw that let's see, not sure why no jobs is left there.

pierDipi · 2022-07-18T13:58:26Z

Maybe the job's TTL is passed and the job removed when the test runs?

skonto · 2022-07-18T14:05:43Z

I will probably move the checks at the beginning of the array as TTL is 600s and see if we have a better chance there.

skonto · 2022-07-18T15:14:20Z

clusterrole.rbac.authorization.k8s.io/admin added: "user1"
Unable to connect to the server: dial tcp: lookup api.ci-ocp-4-10-amd64-aws-us-west-1-m6tc8.hive.aws.ci.openshift.org on 172.30.0.10:53: read udp 10.128.95.41:44754->172.30.0.10:53: i/o timeout
15:00:27.941 ERROR:   🚨 Error (code: 1) occurred at ./test/lib.bash:349, with command: oc adm policy add-role-to-user edit user2 -n "$TEST_NAMESPACE"
15:00:27.942 INFO:    Dumping state...

nak3 · 2022-07-19T00:59:29Z

/retest

mgencur · 2022-07-19T04:13:04Z

+}
+
+func verifyPostInstallServingJobs(ctx context.Context, testCtx *test.Context, c upgrade.Context, cfg VerifyPostJobsConfig) error {
+	jobs, err := testCtx.Clients.Kube.


This function is completely same as verifyPostInstallJobs, except for initializing the clients. I think you could use the same approach as here for Eventing - get the clients from testCtx. Then this whole function could be reused and code duplication removed.

Eventing uses client := testlib.Setup(c.T, false) that does a lot more that is needed behind the scenes eg. try create a namespace. So It is not the same setup. I will remove the code duplication, I wanted first this to pass the tests. ;)
In general it seems Serving is fast but Eventing takes quite some time:

PASS test/upgrade.TestServerlessUpgrade/PostUpgradeTests/Verify_jobs_in_knative-serving (0.03s) PASS test/upgrade.TestServerlessUpgrade/PostUpgradeTests/Verify_jobs_in_knative-eventing (607.77s)

And I think the testlib.Setup is not necessary because we only need the client to work with Jobs resources. We don't create any namespace here.

Yeah ok I cleaned it up for Eventing too ;)

PASS test/upgrade.TestServerlessUpgrade/PostUpgradeTests/Verify_jobs_in_knative-serving (0.03s)
PASS test/upgrade.TestServerlessUpgrade/PostUpgradeTests/Verify_jobs_in_knative-eventing (607.77s)

That's huge 🤔

I think it is related to tear down logic. I hope unification to reduce time for Eventing too.

Still too slow:

PASS test/upgrade.TestServerlessUpgrade/PostUpgradeTests/Verify_jobs_in_knative-serving (5.07s) PASS test/upgrade.TestServerlessUpgrade/PostUpgradeTests/Verify_jobs_in_knative-eventing (620.03s)

I guess polling the jobs takes quite some time there for Eventing. /cc @pierDipi

Ah, I know why, this will change when we bump eventing-kafka-broker (it is due to the KafkaChannel migration)

skonto · 2022-07-19T08:51:49Z

08:42:27.885 DEBUG:   Get the machineset with most replicas
The connection to the server api.ci-ocp-4-10-amd64-aws-us-west-1-zk4ff.hive.aws.ci.openshift.org:6443 was refused - did you specify the right host or port?
08:42:27.981 ERROR:   🚨 Error (code: 1) occurred at ./hack/lib/scaleup.bash:18, with command: current_total="$(oc get machineconfigpool worker -o

skonto · 2022-07-19T10:03:11Z

/retest

skonto · 2022-07-19T11:30:22Z

@mgencur gentle ping.

mgencur · 2022-07-19T11:34:20Z

/lgtm
/hold cancel

openshift-ci · 2022-07-19T11:34:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mgencur,skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierDipi · 2022-07-19T12:45:59Z


Unable to connect to the server: dial tcp: lookup api.ci-ocp-4-10-amd64-aws-us-east-1-rj6mp.hive.aws.ci.openshift.org on 172.30.0.10:53: read udp 10.130.198.212:49673->172.30.0.10:53: i/o timeout

/test 4.10-operator-e2e-aws-ocp-410

add job transformer to eventing, serving

1a572d5

skonto requested review from nak3 and pierDipi July 18, 2022 09:49

skonto assigned mgencur and pierDipi Jul 18, 2022

openshift-ci Bot requested review from alanfx and jcrossley3 July 18, 2022 09:50

openshift-ci Bot added the approved label Jul 18, 2022

skonto mentioned this pull request Jul 18, 2022

Bump to 1.25 #1647

Merged

skonto requested review from mgencur and removed request for alanfx and jcrossley3 July 18, 2022 09:50

skonto changed the title ~~Add job transformer to eventing, serving~~ Add job GeneratedName transformer to eventing, serving Jul 18, 2022

add post-install test

97ab098

openshift-ci Bot added lgtm do-not-merge/hold labels Jul 18, 2022

inject CURRENT_VERSION

957136b

openshift-ci Bot removed the lgtm label Jul 18, 2022

skonto changed the title ~~Add job GeneratedName transformer to eventing, serving~~ [wip] Add job GeneratedName transformer to eventing, serving Jul 18, 2022

openshift-ci Bot added the do-not-merge/work-in-progress label Jul 18, 2022

re-order post upgrade tests

91ef8e0

mgencur reviewed Jul 19, 2022

View reviewed changes

adapt VerifyPostInstallJobs

c2b7758

skonto changed the title ~~[wip] Add job GeneratedName transformer to eventing, serving~~ Add job GeneratedName transformer to eventing, serving Jul 19, 2022

openshift-ci Bot removed the do-not-merge/work-in-progress label Jul 19, 2022

openshift-ci Bot added lgtm and removed do-not-merge/hold labels Jul 19, 2022

openshift-ci Bot merged commit 3967754 into openshift-knative:main Jul 19, 2022

skonto mentioned this pull request Jul 21, 2022

Bump Serving, Eventing to 1.4 for 1.25 #1652

Merged

Conversation

skonto commented Jul 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Uh oh!

mgencur commented Jul 18, 2022

Uh oh!

skonto commented Jul 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skonto commented Jul 18, 2022

Uh oh!

pierDipi commented Jul 18, 2022

Uh oh!

skonto commented Jul 18, 2022

Uh oh!

pierDipi commented Jul 18, 2022

Uh oh!

skonto commented Jul 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skonto commented Jul 18, 2022

Uh oh!

nak3 commented Jul 19, 2022

Uh oh!

mgencur Jul 19, 2022

Choose a reason for hiding this comment

Uh oh!

skonto Jul 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgencur Jul 19, 2022

Choose a reason for hiding this comment

Uh oh!

skonto Jul 19, 2022

Choose a reason for hiding this comment

Uh oh!

pierDipi Jul 19, 2022

Choose a reason for hiding this comment

Uh oh!

skonto Jul 19, 2022

Choose a reason for hiding this comment

Uh oh!

skonto Jul 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pierDipi Jul 19, 2022

Choose a reason for hiding this comment

Uh oh!

skonto commented Jul 19, 2022

Uh oh!

skonto commented Jul 19, 2022

Uh oh!

skonto commented Jul 19, 2022

Uh oh!

mgencur commented Jul 19, 2022

Uh oh!

openshift-ci Bot commented Jul 19, 2022

Uh oh!

pierDipi commented Jul 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

skonto commented Jul 18, 2022 •

edited

Loading

skonto commented Jul 18, 2022 •

edited

Loading

skonto commented Jul 18, 2022 •

edited

Loading

skonto Jul 19, 2022 •

edited

Loading

skonto Jul 19, 2022 •

edited

Loading