Bump Serving, Eventing to 1.4 for 1.25

[skonto]

Proposed Changes

• As per title.
• As in Bump serving, Eventing deps to 1.3.0 #1602
• Split in separate commits for easier review.

[skonto]

Keeping the replacements here:

	k8s.io/api v0.23.5 => k8s.io/api v0.22.5
	k8s.io/apimachinery v0.23.5 => k8s.io/apimachinery v0.22.5
	k8s.io/client-go v0.23.5 => k8s.io/client-go v0.22.5

causes k8s.io/* to be updated to v0.24.3. 0.22.5 does not have those apis. 🤷
Here is what happens:

$ ./hack/update-deps.sh 
go: finding module for package k8s.io/client-go/kubernetes/typed/flowcontrol/v1beta2
go: finding module for package k8s.io/api/flowcontrol/v1beta2
go: finding module for package k8s.io/client-go/applyconfigurations/autoscaling/v2
go: finding module for package k8s.io/api/autoscaling/v2
go: finding module for package k8s.io/client-go/kubernetes/typed/autoscaling/v2
go: finding module for package k8s.io/client-go/applyconfigurations/flowcontrol/v1beta2
go: found k8s.io/api/autoscaling/v2 in k8s.io/api v0.24.3
go: found k8s.io/api/flowcontrol/v1beta2 in k8s.io/api v0.24.3
go: found k8s.io/client-go/applyconfigurations/autoscaling/v2 in k8s.io/client-go v0.24.3
go: found k8s.io/client-go/applyconfigurations/flowcontrol/v1beta2 in k8s.io/client-go v0.24.3
go: found k8s.io/client-go/kubernetes/typed/autoscaling/v2 in k8s.io/client-go v0.24.3
go: found k8s.io/client-go/kubernetes/typed/flowcontrol/v1beta2 in k8s.io/client-go v0.24.3

If we try to go back to 0.22.5 from 0.24.3 then:

github.com/openshift-knative/serverless-operator/openshift-knative-operator/pkg/eventing imports
knative.dev/pkg/client/injection/kube/client imports
	k8s.io/api/autoscaling/v2: module k8s.io/api@latest found (v0.24.3, replaced by k8s.io/api@v0.22.5), but does not contain package k8s.io/api/autoscaling/v2

0.23.5 is for bumping. However not sure if 0.23.5 is ok for OCP 4.6. It should be given the APIs we use. /cc @mgencur

This didnt come up before because knative.dev/pkg updated its generated clients on 1.4 (although the apis existed in go-client version 0.23.4) :
Compare for example for autoscalingv2
https://github.com/knative/pkg/blob/release-1.3/client/injection/kube/client/client.go#L37
vs
https://github.com/knative/pkg/blob/release-1.4/client/injection/kube/client/client.go#L38

So we didnt have the new APIs in 1.3.

[skonto]

/retest

[skonto]

It keeps coming up.

kafka-storage-version-migrator
    postupgrade.go:102: jobs.batch "knative-kafka-storage-version-migrator" not found 
        job:
         {"metadata":{"creationTimestamp":null},"spec":{"template":{"metadata":{"creationTimestamp":null},"spec":{"containers":null}}},"status":{}}

The job exists but the name has now a suffix knative-kafka-storage-version-migrator-1.24.0 and the post upgrade test only checks for knative-kafka-storage-version-migrator. /cc @pierDipi Any idea what is wrong here and why it did pass before?
I see in other runs this being skipped.

[pierDipi]

testing this potential fix #1654

[skonto]

@pierDipi In PR #1648 for example the test was skipped.
Another run from the job history here.
So probably we missed the issue for quite some time?

PASS test/upgrade

=== Skipped
=== SKIP: test/upgrade TestServerlessUpgrade/PostUpgradeTests/BrokerPostUpgradeTest/Verify_post-install (0.00s)
postupgrade.go:64: SO uses different names
--- SKIP: TestServerlessUpgrade/PostUpgradeTests/BrokerPostUpgradeTest/Verify_post-install (0.00s)

=== SKIP: test/upgrade TestServerlessUpgrade/PostUpgradeTests/SinkPostUpgradeTest/Verify_post-install (0.00s)
postupgrade.go:64: SO uses different names
--- SKIP: TestServerlessUpgrade/PostUpgradeTests/SinkPostUpgradeTest/Verify_post-install (0.00s)

Do we test against the full name of the kafka broker job name?

[pierDipi]

Ah, you're right, we miss a patch in eventing-kafka-broker v1.4

[skonto]

@pierDipi pls let me know when the patch lands there so I can re-fetch the dep and try again ok?

[skonto]

/retest

[skonto]

/retest

[pierDipi]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pierDipi,skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[skonto]

/hold for testing 4.6 locally first.

[skonto]

Tested a bit on 4.6.x, some results here.
Didn't notice anything related to the k8s api update, will also verify via the 4.6 periodic jobs.
/unhold