Skip to content

Eventing 0.14 in 1.8 CSV#297

Closed
aliok wants to merge 5 commits into
openshift-knative:masterfrom
aliok:eventing-014-again
Closed

Eventing 0.14 in 1.8 CSV#297
aliok wants to merge 5 commits into
openshift-knative:masterfrom
aliok:eventing-014-again

Conversation

@aliok
Copy link
Copy Markdown
Member

@aliok aliok commented May 12, 2020 •
edited
Loading

Changes:

  • 0.14 eventing images in 1.8 CSV
  • Adaptions for that (deployment names to check is changed; namespace deletion in tooling is changed to proceed in case there's a completed Kubernetes Job pod)
  • Install Zipkin and use it in Eventing (needed to pass the tracing related e2e and conformance tests)

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 12, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aliok
To complete the pull request process, please assign markusthoemmes
You can assign the PR to them by writing /assign @markusthoemmes in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok aliok mentioned this pull request May 12, 2020
Closed
@aliok aliok force-pushed the eventing-014-again branch 8 times, most recently from c740074 to 4c05729 Compare May 15, 2020 08:23
@aliok aliok changed the title [WIP] Eventing 014 again Eventing 0.14 in 1.8 CSV May 15, 2020
@aliok aliok force-pushed the eventing-014-again branch from 4c05729 to 63412d7 Compare May 15, 2020 08:40
markusthoemmes
markusthoemmes reviewed May 15, 2020
View reviewed changes
Comment thread hack/lib/tracing.bash
enable_eventing_tracing
}

function deploy_zipkin {
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes May 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use Openshift Tracing (Jaeger) here?

Copy link
Copy Markdown
Member Author

@aliok aliok May 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. Just trying to make things work honestly.
Maybe we can do that later

Copy link
Copy Markdown
Member Author

@aliok aliok May 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create a JIRA for it after this PR is merged

@aliok
Copy link
Copy Markdown
Member Author

aliok commented May 15, 2020

/retest

Throttling issues at AWS

markusthoemmes
markusthoemmes reviewed May 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small nits, I'm fine if we deploy zipkin like this for now but we should replace it with the Jaeger operator (which would have the nice benefit of being able to claim that Eventing works with Jaeger too).

Comment thread hack/lib/tracing.bash Outdated
Comment thread hack/lib/namespaces.bash
@markusthoemmes
Copy link
Copy Markdown
Contributor

markusthoemmes commented May 15, 2020 

./test/e2e-tests.sh: line 40: install_tracing: command not found

@aliok
Copy link
Copy Markdown
Member Author

aliok commented May 15, 2020

#301 is relevant.

We can merge this one and then change the "replaces" to 1.7.1 once 1.7.1 CSV is in master

@aliok aliok force-pushed the eventing-014-again branch from cfd84c4 to aad9239 Compare May 15, 2020 13:45
@aliok aliok force-pushed the eventing-014-again branch from aad9239 to 870fc67 Compare May 22, 2020 10:05
@aliok
Copy link
Copy Markdown
Member Author

aliok commented May 22, 2020

/test 4.3-e2e-aws-ocp-43

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 30, 2020

@aliok: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aliok aliok mentioned this pull request Jun 8, 2020
Merged
@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 9, 2020

/close

in fav. of #328

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 9, 2020

@matzew: Closed this PR.

Details

In response to this:

/close

in fav. of #328

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aliok aliok deleted the eventing-014-again branch March 9, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgencur mgencur Awaiting requested review from mgencur

@warrenvw warrenvw Awaiting requested review from warrenvw

1 more reviewer

@markusthoemmes markusthoemmes markusthoemmes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aliok @openshift-ci-robot @markusthoemmes @matzew