Skip to content

Knative Eventing 0.14 update#328

Merged
markusthoemmes merged 10 commits into
openshift-knative:masterfrom
matzew:bump_eventing_to_0.14
Jun 17, 2020
Merged

Knative Eventing 0.14 update#328
markusthoemmes merged 10 commits into
openshift-knative:masterfrom
matzew:bump_eventing_to_0.14

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Jun 5, 2020

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

first step to get to 0,14 here

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 5, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: matzew
To complete the pull request process, please assign jcrossley3
You can assign the PR to them by writing /assign @jcrossley3 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 8, 2020

/retest

@aliok
Copy link
Copy Markdown
Member

aliok commented Jun 8, 2020 •
edited
Loading

@matzew
You're gonna need the changes here: #297 for the CI to pass

  • Tracing tests with Zipkin
  • Scripts to ignore completed pods
  • Script var updates
  • CRD update (default broker class)
  • Maybe more image overrides (haven't compared fully)

@matzew matzew force-pushed the bump_eventing_to_0.14 branch from 31334b7 to e287cd0 Compare June 9, 2020 12:20
@matzew matzew mentioned this pull request Jun 9, 2020
Closed
@aliok
Copy link
Copy Markdown
Member

aliok commented Jun 9, 2020

Looks good so far.
Let's see if the build will pass

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 9, 2020

/retest

@matzew matzew changed the title WIP: Some component bump on the CSV for eventing Some component bump on the CSV for eventing Jun 9, 2020
@matzew matzew changed the title Some component bump on the CSV for eventing Knative Eventing 0.14 update Jun 9, 2020
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 9, 2020 via email

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 10, 2020 via email

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 10, 2020 via email

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 10, 2020 via email

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 10, 2020 via email

@matzew matzew force-pushed the bump_eventing_to_0.14 branch from 276ec52 to fc47a37 Compare June 10, 2020 11:47
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 10, 2020

/test 4.5-upgrade-tests-aws-ocp-45

matzew
matzew commented Jun 10, 2020
View reviewed changes
Comment thread olm-catalog/serverless-operator/1.8.0/serverless-operator.v1.8.0.clusterserviceversion.yaml
- name: IMAGE_eventing-controller__JOB_RUNNER_IMAGE
value: registry.svc.ci.openshift.org/openshift/knative-v0.14.2:knative-eventing-jobrunner
- name: IMAGE_eventing-controller__APISERVER_RA_IMAGE
value: registry.svc.ci.openshift.org/openshift/knative-v0.14.2:knative-eventing-apiserver-receive-adapter
Copy link
Copy Markdown
Member Author

@matzew matzew Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the eventing-controller pod, I do see that the ENV VAR for images, like the APISERVER_RA_IMAGE, is actually set to gcr.io, see:

Containers:
  eventing-controller:
    Container ID:   cri-o://3f4753bbf33611691b2dcd52285ff585affebdf4678cfd53e735df56635e7013
    Image:          registry.svc.ci.openshift.org/openshift/knative-v0.14.2:knative-eventing-controller
    Image ID:       registry.svc.ci.openshift.org/openshift/knative-v0.14.2@sha256:075ef8a91762c68ea767cb9db0a71f1310ffa3e36ad292557a7b9a0853b42978
    Ports:          9090/TCP, 8008/TCP
    Host Ports:     0/TCP, 0/TCP
    State:          Running
      Started:      Wed, 10 Jun 2020 12:38:02 +0200
    Ready:          True
    Restart Count:  0
    Requests:
      cpu:     100m
      memory:  100Mi
    Environment:
      SYSTEM_NAMESPACE:           knative-eventing (v1:metadata.namespace)
      CONFIG_LOGGING_NAME:        config-logging
      CONFIG_OBSERVABILITY_NAME:  config-observability
      METRICS_DOMAIN:             knative.dev/eventing
      PING_IMAGE:                 gcr.io/knative-releases/knative.dev/eventing/cmd/ping/adapter@sha256:c7272752928f6eeb9a66cf47c00b2d295ffb8517f2033dbbc8a5f461f6adafc2
      JOB_RUNNER_IMAGE:           gcr.io/knative-releases/knative.dev/eventing/cmd/ping/jobrunner@sha256:b47877189b1e0f23c2617875574b16505251ae45ea091969332266621af99af8
      APISERVER_RA_IMAGE:         gcr.io/knative-releases/knative.dev/eventing/cmd/apiserver_receive_adapter@sha256:717e08da76235229c5664240351ece8c70767768437c0a6d498210cdcc182f14

Copy link
Copy Markdown
Member

@aliok aliok Jun 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matzew are you sure that the deployment name is correct?

not the pod, deployment.

the syntax is IMAGE_<deployment_name>__<env_var>

matzew
matzew commented Jun 10, 2020
View reviewed changes
Comment thread olm-catalog/serverless-operator/1.8.0/serverless-operator.v1.8.0.clusterserviceversion.yaml Outdated
- name: IMAGE_broker-controller__BROKER_INGRESS_IMAGE
image: registry.svc.ci.openshift.org/openshift/knative-v0.14.2:knative-eventing-ingress
- name: IMAGE_broker-controller__BROKER_FILTER_IMAGE
image: registry.svc.ci.openshift.org/openshift/knative-v0.14.2:knative-eventing-filter
Copy link
Copy Markdown
Member Author

@matzew matzew Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like all ENV VARs are not overriden w/ this syntax, example on the broker-controller pod:

Controlled By:      ReplicaSet/broker-controller-587dbd57c
Containers:
  eventing-controller:
    Container ID:   cri-o://c450a61cc95d3b61314919c8a601822cae5a4ad2a047467ac3c0c0cd58fe0a38
    Image:          registry.svc.ci.openshift.org/openshift/knative-v0.14.2:knative-eventing-channel-broker
    Image ID:       registry.svc.ci.openshift.org/openshift/knative-v0.14.2@sha256:a819ed956dd6535d2e89f549b313974081d70e722ce1fc8c67ba91ad82e937ed
    Ports:          9090/TCP, 8008/TCP
    Host Ports:     0/TCP, 0/TCP
    State:          Running
      Started:      Wed, 10 Jun 2020 12:38:09 +0200
    Ready:          True
    Restart Count:  0
    Requests:
      cpu:     100m
      memory:  100Mi
    Environment:
      SYSTEM_NAMESPACE:                knative-eventing (v1:metadata.namespace)
      CONFIG_LOGGING_NAME:             config-logging
      CONFIG_OBSERVABILITY_NAME:       config-observability
      METRICS_DOMAIN:                  knative.dev/eventing
      BROKER_INGRESS_IMAGE:            gcr.io/knative-releases/knative.dev/eventing/cmd/broker/ingress@sha256:cfdaf7a48a22e3bab15e6b15e7ee387eb6406e00e9e4942e58b4a7bc8c2df3cf
      BROKER_INGRESS_SERVICE_ACCOUNT:  eventing-broker-ingress
      BROKER_FILTER_IMAGE:             gcr.io/knative-releases/knative.dev/eventing/cmd/broker/filter@sha256:ad578e71aad9c040087dd621fddd73f70ede4d03ae5425c79e8995d06ebb8aca
      BROKER_FILTER_SERVICE_ACCOUNT:   eventing-broker-filter

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 10, 2020

/retest

1 similar comment
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 10, 2020

/retest

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 10, 2020 via email

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 10, 2020

/retest

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 11, 2020 via email

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 11, 2020

/retest

@matzew matzew force-pushed the bump_eventing_to_0.14 branch from 5d6913a to f5b7e0e Compare June 11, 2020 13:41
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 11, 2020 via email

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 15, 2020 via email

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 16, 2020 via email

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 16, 2020

/retest

1 similar comment
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 16, 2020

/retest

@matzew matzew force-pushed the bump_eventing_to_0.14 branch from 95c91a0 to 096e793 Compare June 16, 2020 15:59
@matzew matzew mentioned this pull request Jun 16, 2020
Closed
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 16, 2020

/test 4.5-e2e-aws-ocp-45

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 16, 2020

/test 4.3-upgrade-tests-aws-ocp-43

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 16, 2020 via email

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 17, 2020 via email

matzew and others added 7 commits June 17, 2020 08:22
@matzew
💫 Bumping image versions to 0.14.x on the CSV for eventing
27da9cb 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@aliok @matzew
Enable tracing for upstream eventing tests
6c97282
@aliok @matzew
Don't block namespace deletion because of completed job pods
cc12cc7
@aliok @matzew
Fix deployment names to check
c49cc2f
@matzew
💄 update to latest CRD for eventing
571334f 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
using overrides for eventing containers
b32d882 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
Updatr operator and test invoke
d8d3fa8 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the bump_eventing_to_0.14 branch from 57483c1 to 571cd0a Compare June 17, 2020 06:28
@matzew
🐳 Updating source container image
d2e4b36 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the bump_eventing_to_0.14 branch from 571cd0a to d2e4b36 Compare June 17, 2020 06:32
@matzew
🐳 Updating source container image
d071a50 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 17, 2020

/test 4.3-e2e-aws-ocp-43

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 17, 2020

/test 4.3-images

@matzew
more more fix :glasses:
884645f 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 17, 2020

/test 4.5-upgrade-tests-aws-ocp-45

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 17, 2020

/test 4.4-upgrade-tests-aws-ocp-44

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 17, 2020

/test 4.5-e2e-aws-ocp-45

@markusthoemmes
Copy link
Copy Markdown
Contributor

markusthoemmes commented Jun 17, 2020

/retest

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 17, 2020

@matzew: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/4.4-upgrade-tests-aws-ocp-44 884645f link /test 4.4-upgrade-tests-aws-ocp-44
ci/prow/4.5-e2e-aws-ocp-45 884645f link /test 4.5-e2e-aws-ocp-45

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@markusthoemmes markusthoemmes merged commit ec7bea3 into openshift-knative:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliok aliok aliok left review comments

@mgencur mgencur Awaiting requested review from mgencur

@warrenvw warrenvw Awaiting requested review from warrenvw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matzew @openshift-ci-robot @aliok @markusthoemmes