-
Notifications
You must be signed in to change notification settings - Fork 75
Knative Eventing 0.14 update #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
markusthoemmes
merged 10 commits into
openshift-knative:master
from
matzew:bump_eventing_to_0.14
Jun 17, 2020
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
27da9cb
:dizzy: Bumping image versions to 0.14.x on the CSV for eventing
matzew 6c97282
Enable tracing for upstream eventing tests
aliok cc12cc7
Don't block namespace deletion because of completed job pods
aliok c49cc2f
Fix deployment names to check
aliok 571334f
:lipstick: update to latest CRD for eventing
matzew b32d882
using overrides for eventing containers
matzew d8d3fa8
Updatr operator and test invoke
matzew d2e4b36
:whale: Updating source container image
matzew d071a50
:whale: Updating source container image
matzew 884645f
more more fix :glasses:
matzew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| function install_tracing { | ||
| deploy_zipkin | ||
| enable_eventing_tracing | ||
| } | ||
|
|
||
| function deploy_zipkin { | ||
| logger.info "Installing Zipkin in namespace ${ZIPKIN_NAMESPACE}" | ||
| cat <<EOF | oc apply -f - || return $? | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: zipkin | ||
| namespace: ${ZIPKIN_NAMESPACE} | ||
| spec: | ||
| type: NodePort | ||
| ports: | ||
| - name: http | ||
| port: 9411 | ||
| selector: | ||
| app: zipkin | ||
| --- | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: zipkin | ||
| namespace: ${ZIPKIN_NAMESPACE} | ||
| spec: | ||
| replicas: 1 | ||
| selector: | ||
| matchLabels: | ||
| app: zipkin | ||
| template: | ||
| metadata: | ||
| labels: | ||
| app: zipkin | ||
| annotations: | ||
| sidecar.istio.io/inject: "false" | ||
| spec: | ||
| containers: | ||
| - name: zipkin | ||
| image: docker.io/openzipkin/zipkin:latest | ||
| ports: | ||
| - containerPort: 9411 | ||
| env: | ||
| - name: POD_NAMESPACE | ||
| valueFrom: | ||
| fieldRef: | ||
| apiVersion: v1 | ||
| fieldPath: metadata.namespace | ||
| resources: | ||
| limits: | ||
| memory: 1000Mi | ||
| requests: | ||
| memory: 256Mi | ||
| --- | ||
| EOF | ||
|
|
||
| logger.info "Waiting until Zipkin is available" | ||
| timeout 600 "[[ \$(oc get pods -n ${ZIPKIN_NAMESPACE} --field-selector=status.phase!=Succeeded -o jsonpath='{.items}') != '[]' ]]" || return 1 | ||
| } | ||
|
|
||
| function enable_eventing_tracing { | ||
| header_text "Configuring tracing for Eventing" | ||
|
|
||
| cat <<EOF | oc apply -f - || return $? | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: config-tracing | ||
| namespace: ${EVENTING_NAMESPACE} | ||
| data: | ||
| enable: "true" | ||
| zipkin-endpoint: "http://zipkin.${ZIPKIN_NAMESPACE}.svc.cluster.local:9411/api/v2/spans" | ||
| sample-rate: "1.0" | ||
| debug: "true" | ||
| EOF | ||
| } | ||
|
|
||
| function teardown_tracing { | ||
| logger.warn 'Teardown tracing' | ||
|
|
||
| oc delete service -n ${ZIPKIN_NAMESPACE} zipkin | ||
| oc delete deployment -n ${ZIPKIN_NAMESPACE} zipkin | ||
|
|
||
| timeout 600 "[[ \$(oc get pods -n ${ZIPKIN_NAMESPACE} --field-selector=status.phase!=Succeeded -o jsonpath='{.items}') != '[]' ]]" || return 2 | ||
|
|
||
| logger.success 'Tracing is uninstalled.' | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the
eventing-controllerpod, I do see that theENV VARfor images, like theAPISERVER_RA_IMAGE, is actually set togcr.io, see:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matzew are you sure that the deployment name is correct?
not the pod, deployment.
the syntax is
IMAGE_<deployment_name>__<env_var>