Skip to content

[WIP] Feature: run upstream serving operator tests#32

Closed
cardil wants to merge 2 commits into
openshift-knative:masterfrom
cardil:feature/run-upstream-serving-tests
Closed

[WIP] Feature: run upstream serving operator tests#32
cardil wants to merge 2 commits into
openshift-knative:masterfrom
cardil:feature/run-upstream-serving-tests

Conversation

@cardil
Copy link
Copy Markdown
Member

@cardil cardil commented Nov 19, 2019

This PR will let us run upstream serving operator tests, a compliance suite, on a serverless operator.

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
To complete the pull request process, please assign vdemeester
You can assign the PR to them by writing /assign @vdemeester in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

Hi @cardil. Thanks for your PR.

I'm waiting for a openshift-knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Copy Markdown
Member

matzew commented Nov 19, 2019

/ok-to-test

@cardil cardil force-pushed the feature/run-upstream-serving-tests branch 4 times, most recently from b5be128 to 225b30e Compare November 25, 2019 17:42
@cardil
Copy link
Copy Markdown
Member Author

cardil commented Nov 26, 2019

/retest

@cardil cardil force-pushed the feature/run-upstream-serving-tests branch 3 times, most recently from 6ff236c to 522deef Compare November 26, 2019 17:09

func TestUpstreamKnativeServingOperator(t *testing.T) {
upstreamtest.ServingOperatorNamespace = "knative-serving"
suite := upstreame2e.ComplianceSuite()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks elegant but hasn't been proposed upstream. I'm not sure it would even be acceptable. Any reason why we're not just running go test on the upstream test and make them configurable to the extent we need?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that way I was able to fine tune what is executed and what isn't - I needed to skip configure subtest due to SRVKS-241

@cardil cardil force-pushed the feature/run-upstream-serving-tests branch 3 times, most recently from c1f42c1 to a0df995 Compare November 28, 2019 10:53
@cardil
Copy link
Copy Markdown
Member Author

cardil commented Nov 28, 2019

/retest

1 similar comment
@cardil
Copy link
Copy Markdown
Member Author

cardil commented Nov 28, 2019

/retest

@cardil cardil force-pushed the feature/run-upstream-serving-tests branch from a0df995 to ce855fb Compare November 28, 2019 11:58
@cardil
Copy link
Copy Markdown
Member Author

cardil commented Nov 28, 2019

/test 4.3-e2e-aws-ocp-43

@openshift-ci-robot
Copy link
Copy Markdown

@cardil: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Feb 12, 2020

I suppose this is out of date? The serving operator tests already run in this repo.

@openshift-ci-robot
Copy link
Copy Markdown

@cardil: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 522deef link /test e2e-aws
ci/prow/unit-test ce855fb link /test unit-test
ci/prow/4.2-upgrade-tests-aws-ocp-42 ce855fb link /test 4.2-upgrade-tests-aws-ocp-42
ci/prow/4.3-upgrade-tests-aws-ocp-43 ce855fb link /test 4.3-upgrade-tests-aws-ocp-43
ci/prow/4.3-vsphere-images ce855fb link /test 4.3-vsphere-images
ci/prow/4.4-e2e-aws-ocp-44 ce855fb link /test 4.4-e2e-aws-ocp-44
ci/prow/4.4-images ce855fb link /test 4.4-images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cardil cardil closed this Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants