[WIP] Feature: run upstream serving operator tests#32
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cardil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @cardil. Thanks for your PR. I'm waiting for a openshift-knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
b5be128 to
225b30e
Compare
|
/retest |
6ff236c to
522deef
Compare
|
|
||
| func TestUpstreamKnativeServingOperator(t *testing.T) { | ||
| upstreamtest.ServingOperatorNamespace = "knative-serving" | ||
| suite := upstreame2e.ComplianceSuite() |
There was a problem hiding this comment.
This looks elegant but hasn't been proposed upstream. I'm not sure it would even be acceptable. Any reason why we're not just running go test on the upstream test and make them configurable to the extent we need?
There was a problem hiding this comment.
In that way I was able to fine tune what is executed and what isn't - I needed to skip configure subtest due to SRVKS-241
c1f42c1 to
a0df995
Compare
|
/retest |
1 similar comment
|
/retest |
a0df995 to
ce855fb
Compare
|
/test 4.3-e2e-aws-ocp-43 |
|
@cardil: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I suppose this is out of date? The serving operator tests already run in this repo. |
|
@cardil: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR will let us run upstream serving operator tests, a compliance suite, on a serverless operator.