Invocation of upstream knative/serving-operator e2e tests#53
Conversation
|
Hi @cardil. Thanks for your PR. I'm waiting for a openshift-knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
cardil
force-pushed
the
feature/run-upstream-serving-tests-v2
branch
4 times, most recently
from
11f4f89 to
489e2aa
Compare
A bash version of test invocation of upstream knative/serving-operator. There is a patch that skips TestKnativeServingDeployment/configure due to SRVKS-241. There is a 0.9.0 version of knative/serving-operator executed, as current serverless operator do not handle knativeservings.operator.knative.dev yet. After supporting that versions should be set to support/v0.10.0. For 0.11 we can use use knative instead of fork (cardil) as master has configurable test namespace.
cardil
force-pushed
the
feature/run-upstream-serving-tests-v2
branch
from
489e2aa to
28edfb1
Compare
|
/retest |
| # Run upstream knative serving tests | ||
| RUN_KNATIVE_SERVING_UPGRADE_TESTS=false | ||
| RUN_KNATIVE_SERVING_E2E=true | ||
| RUN_KNATIVE_SERVING_UPGRADE_TESTS=${RUN_KNATIVE_SERVING_UPGRADE_TESTS:-false} |
There was a problem hiding this comment.
I think we will never want to override it from outside. This concrete script is for running E2E tests, not rolling upgrades. I'm removing these flags in the other PR for separating E2E and Rollups
There was a problem hiding this comment.
I see. So, it will be gone. This change of mine wont damage anything.
|
|
||
| logger.info "Removing GOPATH: ${GOPATH}" | ||
| rm -rf "${GOPATH}" | ||
| popd || return $? |
There was a problem hiding this comment.
We're running in a subshell so this is probably not necessary?
There was a problem hiding this comment.
Yes. Not necessary, but a good practice to restore.
|
|
||
| logger.info "Run tests of knative/serving-operator @ ${gitdesc}" | ||
| env TEST_NAMESPACE='knative-serving' \ | ||
| go test -v -tags=e2e -count=1 -timeout=30m -parallel=1 ./test/e2e \ |
There was a problem hiding this comment.
Let's replace this line with go_test_e2e -tags=e2e -timeout=30m -parallel=1 ./test/e2e \
That way we'll have JUnit reports generated.
There was a problem hiding this comment.
We can fix this in the other PR as well.
|
/lgtm The things I mentioned are rather cosmetic and there's another PR open that touches the code so I'll fix them there. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
A bash version of test invocation of upstream
knative/serving-operator. Previous proposition is #32.There is a patch that skips
TestKnativeServingDeployment/configuredue to SRVKS-241.There is a
0.9.0version ofknative/serving-operatorused, as current serverless operator do not handleknativeservings.operator.knative.devdefinitions yet. After supporting that, versions should be set tosupport/v0.10.0.For
0.11+we can use knative instead of fork (cardil), as master has configurable test namespace knative/serving-operator#223.