Avoid replacing seccompProfile in CRD files #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
skonto
reviewed
Jan 31, 2023
| # 3. Replace serving.knative.dev/release label. | ||
| # 4. Remove seccompProfile, except on CRD files in 300-resources folder to avoid breaking CRDs. | ||
| if [[ $file == config/core//300-resources/* ]]; then | ||
| if [[ $file == */300-resources/* ]]; then |
There was a problem hiding this comment.
Another option would be to remove slashes with echo $file | sed s#//*#/#g.
|
/lgtm hold for tests |
|
/lgtm |
Author
|
Tests are passing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ReToCode
added a commit
that referenced
this pull request
Feb 14, 2023
openshift-merge-robot
pushed a commit
that referenced
this pull request
Mar 8, 2023
* [SRVKS-988] Drop duplicate manifests (#81) * Drop duplicate manifests * keep * Drop openshift/release/artifacts * Add correct version * Revert Makefile * Set label version based on the branch name * [SRVKS-1000] Use SO repo's script to install serverless (#89) * Drop CI yamls * Avoid replacing seccompProfile in CRD files (#148) * Fix seccompProfile: * Drop 006-secure-pod-defaults.patch * Fix invalid new line in domainmapping --------- Co-authored-by: Reto Lehmann <retocode@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script is called for multiple paths, unfortunately the different base paths result in different amount of trailing/leading slashes:
vs.
Tested in #147
/hold for tests