Skip to content

Conversation

@nak3
Copy link

@nak3 nak3 commented Mar 8, 2023

This patch contains the following fixes:

Also, this patch cherry-picks the following PRs for maintainability:

@nak3 nak3 changed the title [release-v1.7] Fix wrong manifests in 1.7 [release-v1.7] Fix invalid manifests Mar 8, 2023
@openshift-ci openshift-ci bot requested review from mgencur and mvinkler March 8, 2023 02:47
@openshift-ci openshift-ci bot added the approved label Mar 8, 2023
@nak3
Copy link
Author

nak3 commented Mar 8, 2023

/cc @skonto @ReToCode @mgencur

openshift-knative/serverless-operator#1990 verified this change.

@openshift-ci openshift-ci bot requested review from ReToCode and skonto March 8, 2023 03:56
Copy link

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link

skonto commented Mar 8, 2023

@nak3 A missing new line at the end of file makes the yaml invalid?

@nak3
Copy link
Author

nak3 commented Mar 8, 2023

@nak3 A missing new line at the end of file makes the yaml invalid?

Yes, openshift/release/resolve.sh assumed that the files have it so it caused the following invalid yaml:
openshift-knative/serverless-operator@80d8401#diff-afcb8cb79053a14a8bd4e3cf30f5342402b75a7e615010efc04daa68de18889aR6344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants