-
Notifications
You must be signed in to change notification settings - Fork 8
[release-v1.7] Fix invalid manifests #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v1.7] Fix invalid manifests #200
Conversation
* Drop duplicate manifests * keep * Drop openshift/release/artifacts * Add correct version * Revert Makefile * Set label version based on the branch name
|
/cc @skonto @ReToCode @mgencur openshift-knative/serverless-operator#1990 verified this change. |
ReToCode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@nak3 A missing new line at the end of file makes the yaml invalid? |
Yes, |
This patch contains the following fixes:
domainmapping-controller.yaml)1-serving-crds.yamlin [RELEASE-1.7][SRVKS-985] Add sec default no seccomp #194Also, this patch cherry-picks the following PRs for maintainability: