Make it more clear the instructions expect a fork #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two people have so far run into issues with these docs b/c they missed the instruction to fork the repo, so hopefully outlining it clearly as a step will make this easier.
mattmoor
approved these changes
Feb 6, 2018
matzew
pushed a commit
to matzew/serving
that referenced
this pull request
May 2, 2019
Add the newly added networking controller to the images to build.
tcnghia
pushed a commit
to tcnghia/serving
that referenced
this pull request
Jun 8, 2020
Also adds Contour to the set of things we bump in our upgrades.
nak3
added a commit
to nak3/serving
that referenced
this pull request
Dec 20, 2022
* Drop duplicate manifests * keep * Drop openshift/release/artifacts * Add correct version * Revert Makefile * Set label version based on the branch name
nak3
added a commit
to nak3/serving
that referenced
this pull request
Mar 3, 2023
* Drop duplicate manifests * keep * Drop openshift/release/artifacts * Add correct version * Revert Makefile * Set label version based on the branch name
nak3
added a commit
to nak3/serving
that referenced
this pull request
Mar 3, 2023
* Drop duplicate manifests * keep * Drop openshift/release/artifacts * Add correct version * Revert Makefile * Set label version based on the branch name
nak3
added a commit
to nak3/serving
that referenced
this pull request
Mar 3, 2023
* Drop duplicate manifests * keep * Drop openshift/release/artifacts * Add correct version * Revert Makefile * Set label version based on the branch name
nak3
added a commit
to nak3/serving
that referenced
this pull request
Mar 3, 2023
* Drop duplicate manifests * keep * Drop openshift/release/artifacts * Add correct version * Revert Makefile * Set label version based on the branch name
nak3
added a commit
to nak3/serving
that referenced
this pull request
Mar 8, 2023
* [SRVKS-988] Drop duplicate manifests (knative#81) * Drop duplicate manifests * keep * Drop openshift/release/artifacts * Add correct version * Revert Makefile * Set label version based on the branch name * [SRVKS-1000] Use SO repo's script to install serverless (knative#89) * Bump artifacts manifests
nak3
added a commit
to nak3/serving
that referenced
this pull request
Mar 8, 2023
* Drop duplicate manifests * keep * Drop openshift/release/artifacts * Add correct version * Revert Makefile * Set label version based on the branch name
nak3
added a commit
to nak3/serving
that referenced
this pull request
Mar 8, 2023
* [SRVKS-988] Drop duplicate manifests (knative#81) * Drop duplicate manifests * keep * Drop openshift/release/artifacts * Add correct version * Revert Makefile * Set label version based on the branch name * [SRVKS-1000] Use SO repo's script to install serverless (knative#89) * Drop CI yamls * Avoid replacing seccompProfile in CRD files (knative#148) * Fix seccompProfile: * Drop 006-secure-pod-defaults.patch * Fix invalid new line in domainmapping --------- Co-authored-by: Reto Lehmann <retocode@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two people have so far run into issues with these docs b/c they missed the instruction to fork the repo, so hopefully outlining it clearly as a step will make this easier.