Use rev for revision variables everywhere #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanweiguo
approved these changes
Feb 21, 2018
drewinglis
approved these changes
Feb 21, 2018
Contributor
drewinglis
left a comment
drewinglis
left a comment
There was a problem hiding this comment.
"hr"... now that's a variable name I haven't heard in a long time...
nak3
pushed a commit
to nak3/serving
that referenced
this pull request
Jul 31, 2019
Collect openshift-ingress logs and routes
nak3
added a commit
to nak3/serving
that referenced
this pull request
Mar 8, 2023
* [SRVKS-988] Drop duplicate manifests (knative#81) * Drop duplicate manifests * keep * Drop openshift/release/artifacts * Add correct version * Revert Makefile * Set label version based on the branch name * [SRVKS-1000] Use SO repo's script to install serverless (knative#89) * Drop CI yamls * Avoid replacing seccompProfile in CRD files (knative#148) * Fix seccompProfile: * Drop 006-secure-pod-defaults.patch * Fix invalid new line in domainmapping --------- Co-authored-by: Reto Lehmann <retocode@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More missed variable renames.