Add go dep command to requirements. #103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to build some go repositories.
Collaborator
|
which repo building fails without this? |
Contributor
Author
|
None of these directly. The operator-sdk needs it. |
Member
|
The operator-sdk needs it, and operator-sdk is needed by metalkube/baremetal-operator |
Member
|
/lgtm |
hardys
approved these changes
Mar 5, 2019
hardys
reviewed
Mar 5, 2019
| sudo yum install yarn nodejs -y | ||
|
|
||
| # Install go dep command. The packaged version is too old. This is for development only atm. | ||
| export GOPATH=$HOME/go |
There was a problem hiding this comment.
Rather than hard-coding this, should we either do eval "$(go env)" or source ocp_install_env.sh which already does that?
russellb
requested changes
Mar 13, 2019
| mkdir -p $GOPATH/go/bin | ||
| curl -o /tmp/install-go-dep.sh https://raw.githubusercontent.com/golang/dep/master/install.sh | ||
| chmod 755 /tmp/install-go-dep.sh | ||
| /tmp/install-go-dep.sh |
Member
There was a problem hiding this comment.
instead of the tmp file, how about
curl https://raw.githubusercontent.com/golang/dep/master/install.sh | sh
There was a problem hiding this comment.
I think this has been obsoleted by #139 which did exactly that
Contributor
There was a problem hiding this comment.
Yes, #139 takes care of installing dep and operator-sdk.
|
Obsoleted by #139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to build some go repositories.