Skip to content

Add go dep command to requirements. #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imain wants to merge 1 commit into from
Closed

Add go dep command to requirements. #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions 01_install_requirements.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,10 @@ fi
curl --silent --location https://dl.yarnpkg.com/rpm/yarn.repo | sudo tee /etc/yum.repos.d/yarn.repo
curl --silent --location https://rpm.nodesource.com/setup_10.x | sudo bash -
sudo yum install yarn nodejs -y

# Install go dep command. The packaged version is too old. This is for development only atm.
export GOPATH=$HOME/go
Copy link

@hardys hardys Mar 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than hard-coding this, should we either do eval "$(go env)" or source ocp_install_env.sh which already does that?

Copy link
Member

@russellb russellb Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to eval "$(go env)"

mkdir -p $GOPATH/go/bin
curl -o /tmp/install-go-dep.sh https://raw.githubusercontent.com/golang/dep/master/install.sh
chmod 755 /tmp/install-go-dep.sh
/tmp/install-go-dep.sh
Copy link
Member

@russellb russellb Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of the tmp file, how about

curl https://raw.githubusercontent.com/golang/dep/master/install.sh | sh

Copy link

@hardys hardys Mar 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has been obsoleted by #139 which did exactly that

Copy link
Contributor

@sadasu sadasu Mar 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, #139 takes care of installing dep and operator-sdk.