Add unit to time in "podman wait" command.

[hroyrh]

Changes made in 04_setup_ironic.sh file to fix error raised when podman wait executes with no unit for time.

[openshift-ci-robot]

Hi @hroyrh. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stbenjam]

1000s is too long, the -i is the check interval, which means podman won't check for completion until after 16 minutes. Maybe do ms?

The podman-wait manpage does not document that a unit is required:

       --interval, -i=microseconds
         Microseconds to wait before polling for completion

And breaking working functionality is a problem. We should file a bug against podman for this.

[stbenjam]

I filed a bug about the podman issue, https://bugzilla.redhat.com/show_bug.cgi?id=1897282

[hroyrh]

1000s is too long, the -i is the check interval, which means podman won't check for completion until after 16 minutes. Maybe do ms?

I have changed it to ms.

The podman-wait manpage does not document that a unit is required:

       --interval, -i=microseconds
         Microseconds to wait before polling for completion

And breaking working functionality is a problem. We should file a bug against podman for this.

Thanks for filing the bug, yes we need clarification on this.

[hardys]

/ok-to-test

[stbenjam]

/retest

Network issues?
curl: (35) OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to mirror.openshift.com:443

[stbenjam]

/lgtm

[stbenjam]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dtantsur]

Folks, this patch is broken, 1000ms is not a valid syntax..

$ sudo podman wait -i 1000ms ipa-downloader
Error: invalid argument "1000ms" for "-i, --interval" flag: strconv.ParseUint: parsing "1000ms": invalid syntax