Skip to content

baremetal: add units to podman wait in ironic#4377

Closed
stbenjam wants to merge 1 commit intoopenshift:masterfrom
stbenjam:podman-wait-units
Closed

baremetal: add units to podman wait in ironic#4377
stbenjam wants to merge 1 commit intoopenshift:masterfrom
stbenjam:podman-wait-units

Conversation

@stbenjam
Copy link
Copy Markdown
Member

A bug in some versions of podman
means that units end up being required for the podman wait command, even
though it was documented as optional. This is fixed, but the podman
requiring units shipped in RHEL 8.3 and recent Fedoras, and won't be
updated until 8.4. This proactively adds units to baremetal's
podman-wait commands in case this broken podman ends up in RHCOS or
FCOS. It doesn't hurt to be explicit anyway.

@stbenjam
Copy link
Copy Markdown
Member Author

/label baremetal

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@stbenjam: The label(s) /label baremetal cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed

Details

In response to this:

/label baremetal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Copy Markdown
Member Author

/label platform/baremetal

@openshift-ci-robot openshift-ci-robot added the platform/baremetal IPI bare metal hosts platform label Nov 13, 2020
@stbenjam
Copy link
Copy Markdown
Member Author

Similar change to dev-scripts: openshift-metal3/dev-scripts#1148

A [bug in some versions of podman](https://bugzilla.redhat.com/show_bug.cgi?id=1897282)
means that units end up being required for the podman wait command, even
though it was documented as optional. This is fixed, but the podman
requiring units shipped in RHEL 8.3 and recent Fedoras, and won't be
updated until 8.4.  This proactively adds units to baremetal's
podman-wait commands in case this broken podman ends up in RHCOS or
FCOS. It doesn't hurt to be explicit anyway.
@stbenjam
Copy link
Copy Markdown
Member Author

/assign @hardys

@hardys
Copy link
Copy Markdown

hardys commented Nov 13, 2020

/approve

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

@stbenjam: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 57c21f6 link /test e2e-crc
ci/prow/e2e-ovirt 57c21f6 link /test e2e-ovirt
ci/prow/e2e-openstack 57c21f6 link /test e2e-openstack
ci/prow/e2e-metal-ipi 57c21f6 link /test e2e-metal-ipi
ci/prow/e2e-aws-fips 57c21f6 link /test e2e-aws-fips
ci/prow/e2e-aws-upgrade 57c21f6 link /test e2e-aws-upgrade
ci/prow/e2e-aws-workers-rhel7 57c21f6 link /test e2e-aws-workers-rhel7
ci/prow/e2e-aws 57c21f6 link /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam
Copy link
Copy Markdown
Member Author

/hold

Need to investigate the failure, it happened early on bootstrap and of course we got no logs out of CI because of #3927

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2020
@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Dec 9, 2020

This was included with #4414

/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@stbenjam: Closed this PR.

Details

In response to this:

This was included with #4414

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam stbenjam deleted the podman-wait-units branch December 9, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. platform/baremetal IPI bare metal hosts platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants