baremetal: add units to podman wait in ironic#4377
baremetal: add units to podman wait in ironic#4377stbenjam wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
/label baremetal |
|
@stbenjam: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label platform/baremetal |
|
Similar change to dev-scripts: openshift-metal3/dev-scripts#1148 |
A [bug in some versions of podman](https://bugzilla.redhat.com/show_bug.cgi?id=1897282) means that units end up being required for the podman wait command, even though it was documented as optional. This is fixed, but the podman requiring units shipped in RHEL 8.3 and recent Fedoras, and won't be updated until 8.4. This proactively adds units to baremetal's podman-wait commands in case this broken podman ends up in RHCOS or FCOS. It doesn't hurt to be explicit anyway.
4585a11 to
57c21f6
Compare
|
/assign @hardys |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold Need to investigate the failure, it happened early on bootstrap and of course we got no logs out of CI because of #3927 |
|
This was included with #4414 /close |
|
@stbenjam: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
A bug in some versions of podman
means that units end up being required for the podman wait command, even
though it was documented as optional. This is fixed, but the podman
requiring units shipped in RHEL 8.3 and recent Fedoras, and won't be
updated until 8.4. This proactively adds units to baremetal's
podman-wait commands in case this broken podman ends up in RHCOS or
FCOS. It doesn't hurt to be explicit anyway.