Skip to content

Fetch oc tools from different URL#1164

Merged
openshift-merge-robot merged 1 commit intoopenshift-metal3:masterfrom
stbenjam:client-url
Dec 2, 2020
Merged

Fetch oc tools from different URL#1164
openshift-merge-robot merged 1 commit intoopenshift-metal3:masterfrom
stbenjam:client-url

Conversation

@stbenjam
Copy link
Copy Markdown
Member

@stbenjam stbenjam commented Dec 2, 2020

The current URL we are using for oc was removed, so we need to get the
tools from another location. This also removes the dependency on
calculating the version based on the pullspec, meaning this code works
for CI builds too.

We only use these tools to bootstrap getting the ones from the release
payload, so the actual version isn't super important as we just
overwrite it anyway a little bit later on.

@hardys
Copy link
Copy Markdown

hardys commented Dec 2, 2020

/approve

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
The current URL we are using for `oc` was removed, so we need to get the
tools from another location. This also removes the dependency on
calculating the version based on the pullspec, meaning this code works
for CI builds too.

We only use these tools to bootstrap getting the ones from the release
payload, so the actual version isn't super important as we just
overwrite it anyway a little bit later on.
@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Dec 2, 2020

Tested locally:

+(./01_install_requirements.sh:48): main(): curl --retry 5 https://mirror.openshift.com/pub/openshift-v4/clients/ocp/stable/openshift-client-linux.tar.gz
+(./01_install_requirements.sh:48): main(): sudo tar -U -C /usr/local/bin -xzf -
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 23.1M  100 23.1M    0     0  14.6M      0  0:00:01  0:00:01 --:--:-- 14.6M
+(./01_install_requirements.sh:49): main(): sudo chmod +x /usr/local/bin/oc
+(./01_install_requirements.sh:50): main(): oc version --client -o json
{
  "clientVersion": {
    "major": "",
    "minor": "",
    "gitVersion": "openshift-clients-4.6.0-202006250705.p0-164-gffd683609",
    "gitCommit": "ffd68360997854d442e2ad2f40b099f5198b6471",
    "gitTreeState": "clean",
    "buildDate": "2020-11-04T21:37:21Z",
    "goVersion": "go1.15.0",
    "compiler": "gc",
    "platform": "linux/amd64"
  },
  "releaseClientVersion": "4.6.4"
}
+(./01_install_requirements.sh:1): main(): removetmp
+(utils.sh:509): removetmp(): '[' -n ' /tmp/test-token--AwqtwieOAC' ']'
+(utils.sh:509): removetmp(): rm -rf /tmp/test-token--AwqtwieOAC

CI will fail this, as we need this PR and the release repo one. Overriding CI (discussed on Slack)

/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-ci-robot
Copy link
Copy Markdown

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-metal-ipi, ci/prow/e2e-metal-ipi-ovn-ipv6

Details

In response to this:

Tested locally:

+(./01_install_requirements.sh:48): main(): curl --retry 5 https://mirror.openshift.com/pub/openshift-v4/clients/ocp/stable/openshift-client-linux.tar.gz
+(./01_install_requirements.sh:48): main(): sudo tar -U -C /usr/local/bin -xzf -
 % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                Dload  Upload   Total   Spent    Left  Speed
100 23.1M  100 23.1M    0     0  14.6M      0  0:00:01  0:00:01 --:--:-- 14.6M
+(./01_install_requirements.sh:49): main(): sudo chmod +x /usr/local/bin/oc
+(./01_install_requirements.sh:50): main(): oc version --client -o json
{
 "clientVersion": {
   "major": "",
   "minor": "",
   "gitVersion": "openshift-clients-4.6.0-202006250705.p0-164-gffd683609",
   "gitCommit": "ffd68360997854d442e2ad2f40b099f5198b6471",
   "gitTreeState": "clean",
   "buildDate": "2020-11-04T21:37:21Z",
   "goVersion": "go1.15.0",
   "compiler": "gc",
   "platform": "linux/amd64"
 },
 "releaseClientVersion": "4.6.4"
}
+(./01_install_requirements.sh:1): main(): removetmp
+(utils.sh:509): removetmp(): '[' -n ' /tmp/test-token--AwqtwieOAC' ']'
+(utils.sh:509): removetmp(): rm -rf /tmp/test-token--AwqtwieOAC

CI will fail this, as we need this PR and the release repo one. Overriding CI (discussed on Slack)

/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam stbenjam added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Dec 2, 2020

/refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants