Skip to content

baremetalds: don't download oc tools outside of dev-scripts#14012

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:oc-url
Dec 2, 2020
Merged

baremetalds: don't download oc tools outside of dev-scripts#14012
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:oc-url

Conversation

@stbenjam
Copy link
Copy Markdown
Member

@stbenjam stbenjam commented Dec 2, 2020

We can rely on dev-scripts to download the tools for us now as it uses a static URL: openshift-metal3/dev-scripts#1164, so there's no need to hardcode this URL. The URL we're using here was also removed from the mirror, so it's causing metal ipi jobs to fail.

We can rely on dev-scripts to download the tools for us now, so there's
no need to hardcode this URL. The URL we're using here was also removed
from the mirror, so it's causing metal ipi jobs to fail.
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@stbenjam stbenjam marked this pull request as ready for review December 2, 2020 13:08
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2020
@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Dec 2, 2020

Looks like the changes from my dev-scripts PR haven't propagated to the dev-scripts container image yet.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Dec 2, 2020

@stbenjam: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-baremetal-operator/master/e2e-metal-ipi-upgrade 766e5db link /test pj-rehearse
ci/rehearse/openshift/cluster-baremetal-operator/master/e2e-metal-ipi-ovn-dualstack 766e5db link /test pj-rehearse
ci/prow/pj-rehearse 766e5db link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Dec 2, 2020

/test pj-rehearse

@andfasano
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 528a124 into openshift:master Dec 2, 2020
@stbenjam stbenjam deleted the oc-url branch December 2, 2020 15:23
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@stbenjam: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key baremetalds-devscripts-setup-commands.sh using file ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key baremetalds-devscripts-setup-commands.sh using file ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh
Details

In response to this:

We can rely on dev-scripts to download the tools for us now as it uses a static URL: openshift-metal3/dev-scripts#1164, so there's no need to hardcode this URL. The URL we're using here was also removed from the mirror, so it's causing metal ipi jobs to fail.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants